Bug 2588 - libpixbuf does not compile on Solaris with Forte
Summary: libpixbuf does not compile on Solaris with Forte
Status: RESOLVED FIXED
Alias: None
Product: pixman
Classification: Unclassified
Component: pixman (show other bugs)
Version: 0.1.3
Hardware: SPARC Solaris
: high normal
Assignee: Carl Worth
QA Contact: cairo-bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-21 10:44 UTC by Brian Cameron
Modified: 2007-06-20 09:29 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Brian Cameron 2005-02-21 10:44:58 UTC
The Sun Forte compiler does not support "__inline".  Some of the cairo source
uses logic like this to use this GCC extension:

#ifndef __GNUC__
#define __inline
#endif

But the file src/icimage.c doesn't, so it fails to compile unless you add
these lines.

Sun Forte does support "inline", though.  The glib module uses some
AC_COMPILE_IFELSE statements in its configure.in to see if __inline, ___inline,
or inline is supported and sets it appropriately.  Could this code be copied
into cairo so it is more platform independant?
Comment 1 Carl Worth 2005-02-21 13:00:29 UTC
I've moved the definition of __inline from ic.c to icint.h in CVS.
This should fix icimage.c so that it now compiles.

If you'd like to provide a patch to support inline functions on more systems,
that would be welcome. I hesitate to blindly copy from another project myself,
since I don't have any such systems available for testing.
Comment 2 Søren Sandmann Pedersen 2007-06-20 09:29:50 UTC
The new libpixman library just uses inline, so this should be fixed. Feel free to file a new bug if there are other problems with the Sun compilers.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.