Bug 25909 - [PATCH] #ifdefs in include/eventstr.h:EventType enum can break modules
Summary: [PATCH] #ifdefs in include/eventstr.h:EventType enum can break modules
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-06 01:36 UTC by Adam Tkac
Modified: 2010-01-07 17:30 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
proposed patch (859 bytes, patch)
2010-01-06 01:36 UTC, Adam Tkac 		no flags Details | Splinter Review
View All

Description Adam Tkac 2010-01-06 01:36:29 UTC 
Created attachment 32469 [details] [review]
proposed patch

#ifdefs in include/eventstr.h:EventType enum can break modules.

Main problem is that EventType enumeration members can be different in module and in server, which obviously causes problems. Would it be possible to merge proposed patch to both master and 1.7 branches, please? Thanks.
Comment 1 Alan Coopersmith 2010-01-06 07:17:37 UTC 
To get patches applied to the master & 1.7 branches it's best for them
to be mailed to xorg-devel for review.   See the instructions at:
http://www.x.org/wiki/XServer   and
http://www.x.org/wiki/Development/Documentation/SubmittingPatches
Comment 2 Peter Hutterer 2010-01-07 17:30:41 UTC 
now in both master and 1.7.4.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.