Bug 26110 - Implement EnsureChannel for Call channels.
Summary: Implement EnsureChannel for Call channels.
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Sjoerd Simons
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/ma...
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2010-01-18 18:40 UTC by Mike Ruprecht
Modified: 2010-01-22 06:50 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Mike Ruprecht 2010-01-18 18:40:29 UTC 
See summary.
Comment 1 Sjoerd Simons 2010-01-20 10:01:50 UTC 
Seems bugzilla ate my comments:
  Basically when ensuring a channle you need to also check the list of pending call channels and add the reqest token to the MCR if applicable.
Comment 2 Mike Ruprecht 2010-01-20 21:06:03 UTC 
Updated the branch per your review comments.

I didn't get to testing this yet. The ChannelDispatcher kept eating my EnsureChannel request. Feel free to look over it though. I can spend some more time to test it correctly tomorrow.
Comment 3 Sjoerd Simons 2010-01-21 03:51:22 UTC 
THe code looks good to me, but some ensurance that it works would be nice :).. Also tests!
Comment 4 Mike Ruprecht 2010-01-21 19:24:30 UTC 
Updated the branch per your review comments. (I did find a few things wrong. oops. yay for testing)
Comment 5 Sjoerd Simons 2010-01-22 06:50:11 UTC 
Looks ok, merging.

Note that once we delay the media channel untill we got the disco caps of the remote party we can deterministically test the case where we ensure a channel that is internally in pending state

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.