Bug 26112 - Several misc fixes for the new media spec.
Summary: Several misc fixes for the new media spec.
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Mike Ruprecht
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/ma...
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2010-01-18 21:38 UTC by Mike Ruprecht
Modified: 2010-01-21 03:49 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Mike Ruprecht 2010-01-18 21:38:59 UTC
See summary. For the commits regarding the call being in the Ended state, I'm wondering if it would be better to improve freeing of the call instead of those commits.
Comment 1 Sjoerd Simons 2010-01-20 04:57:47 UTC
If branches aren't related you should try to not stack them, so they can merged one by one

348ef09:

  "Call channel must contain at least "
  "one InitialAudio or InitialVideo");

=> at least one of

5d337f6:
  debug message when accept is called in a valid state would be good. or generally when a client does something you didn't expect.


The last few commits aren't really misc fixes, but look good anyway :)
Comment 2 Mike Ruprecht 2010-01-20 15:11:41 UTC
Updated my branch per your review comments.

(In reply to comment #1)
> If branches aren't related you should try to not stack them, so they can merged
> one by one

and

> The last few commits aren't really misc fixes, but look good anyway :)

I pulled the last few commits out as they rely on two of the other pending branches. I will make a new bug for it when they are merged.
Comment 3 Sjoerd Simons 2010-01-21 03:49:06 UTC
Merged, thanks


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.