Bug 26388 - Implement Debug interface
Summary: Implement Debug interface
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: rakia (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Mikhail Zabaluev
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/jo...
Whiteboard:
Keywords: patch
Depends on: 26393
Blocks:
  Show dependency treegraph
 
Reported: 2010-02-02 07:50 UTC by Jonny Lamb
Modified: 2010-02-16 00:28 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Jonny Lamb 2010-02-02 07:50:23 UTC
I enclose:

 1x git branch implementing the said feature.
Comment 1 Mikhail Zabaluev 2010-02-02 08:37:40 UTC
(In reply to comment #0)
>  1x git branch implementing the said feature.

* I don't like how we use integer flags to efficiently switch off debug messages, but the sender stuff bypasses that, always allocates and formats a debug string, and does a hash lookup to get back the string domain on every potentially no-op debug statement. Get everything back under that flag check?

* log_to_debug_sender: just keep a static reference to the logger instead of useless reffing and unreffing for every log message?
Comment 2 Mikhail Zabaluev 2010-02-02 09:13:05 UTC
(In reply to comment #1)
> * I don't like how we use integer flags to efficiently switch off debug
> messages, but the sender stuff bypasses that, always allocates and formats a
> debug string, and does a hash lookup to get back the string domain on every
> potentially no-op debug statement. Get everything back under that flag check?

I got explained that the logger is disabled by default.
We need something like tp_debug_sender_is_enabled() (see the dependency bug #26393), so you don't have to run a property get every time you want to check if the logger is enabled before formatting varargs into the message and handing it to the logger.
Comment 3 Mikhail Zabaluev 2010-02-03 05:24:35 UTC
After some pondering and explanation, I retract the objections made in comment #1.
The branch is merged to remote master.
Comment 4 Mikhail Zabaluev 2010-02-16 00:28:42 UTC
The fix is merged upstream and available under tag telepathy-sofiasip-0.6.0, pending a proper fd.o release Real Soon Now.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.