Bug 26649 - disable plazes if it gives unuseful results.
Summary: disable plazes if it gives unuseful results.
Status: RESOLVED FIXED
Alias: None
Product: GeoClue
Classification: Unclassified
Component: Master Server (obsolete) (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Geoclue Bugs
QA Contact: Geoclue Bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-19 06:43 UTC by arno
Modified: 2010-03-25 14:43 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
patch v1 (5.34 KB, patch)
2010-02-19 09:01 UTC, arno 		Details | Splinter Review
patch v1.1 (5.27 KB, patch)
2010-02-25 13:42 UTC, arno 		Details | Splinter Review
Show Obsolete (1) View All

Description arno 2010-02-19 06:43:19 UTC 
Hi,
Let's say, I have plazes and hostip providers installed.
But unfortunately, plazes does not povides me useful results. plazes send me a xml document with just en empty "<suggestions></suggestions>" tag.
So, it would be nice to disable plazes when result is unuseful, therefore, geoclue could try to get results from hostip.
Comment 1 Jussi Kukkonen [inactive] 2010-02-19 06:51:03 UTC 
(In reply to comment #0)
> Hi,
> Let's say, I have plazes and hostip providers installed.
> But unfortunately, plazes does not povides me useful results. plazes send me a
> xml document with just en empty "<suggestions></suggestions>" tag.
> So, it would be nice to disable plazes when result is unuseful, therefore,
> geoclue could try to get results from hostip.
> 

That is definitely how it should work. I'm seeing the same thing (as I mentioned in 22160), Plazes gets chosen even though it clearly has no real data.
Comment 2 arno 2010-02-19 06:52:46 UTC 
I'll try to work on it.
Comment 3 arno 2010-02-19 09:01:12 UTC 
Created attachment 33424 [details] [review]
patch v1

here is a fix proposal.
Comment 4 arno 2010-02-25 13:42:22 UTC 
Created attachment 33573 [details] [review]
patch v1.1

updated patch to apply against current HEAD
Comment 5 Jussi Kukkonen [inactive] 2010-03-25 14:43:15 UTC 
thanks, in master now.

I'll try to release Very Soon Now.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.