Bug 26751 - Initial versions of WockyPubsub{Service,Node}
Summary: Initial versions of WockyPubsub{Service,Node}
Status: RESOLVED FIXED
Alias: None
Product: Wocky
Classification: Unclassified
Component: General (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Guillaume Desmottes
QA Contact: Sjoerd Simons
URL: http://git.collabora.co.uk/?p=user/wj...
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2010-02-25 06:25 UTC by Will Thompson
Modified: 2010-02-26 03:41 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Will Thompson 2010-02-25 06:25:28 UTC
I've brought Guillaume's PubSub branch up to date atop the freshly-merged data forms stuff, reviewed it, fixed my criticisms.
Comment 1 Guillaume Desmottes 2010-02-26 03:34:04 UTC
"Conventionally, the _async function is used as the source tag, not the _finish function."
rly? AFAIK we always use the _finish function in Wocky.

Branch looks good otherwise.
Comment 2 Will Thompson 2010-02-26 03:41:29 UTC
(In reply to comment #1)
> "Conventionally, the _async function is used as the source tag, not the _finish
> function."
> rly? AFAIK we always use the _finish function in Wocky.

Yes:

gboolean            g_simple_async_result_is_valid      (GAsyncResult *result,
                                                         GObject *source,
                                                         gpointer source_tag);
Third, source_tag is checked to ensure that it is equal to the source_tag argument given to g_simple_async_result_new() (which, by convention, is a pointer to the _async function corresponding to the _finish function from which this function is called).

Merged; thanks!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.