Bug 26843 - Log spam when devices are detached
Summary: Log spam when devices are detached
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: 7.5 (2009.10)
Hardware: Other All
: medium normal
Assignee: Peter Hutterer
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-02 10:13 UTC by Tom Jaeger
Modified: 2013-01-11 05:31 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
patch (2.83 KB, patch)
2010-03-02 10:13 UTC, Tom Jaeger
no flags Details | Splinter Review

Description Tom Jaeger 2010-03-02 10:13:00 UTC
On 1.7.5, each time a device gets detached, the server logs the following messages:

[mi] miSpriteRealizeCursor called for floating device.
[mi] miSpriteSetCursor called for floating device.
[mi] miSpriteSetCursor called for floating device.
[mi] miSpriteRealizeCursor called for floating device.
[mi] miSpriteSetCursor called for floating device.
[mi] miSpriteRealizeCursor called for floating device.
[mi] miSpriteSetCursor called for floating device.
[mi] miSpriteRealizeCursor called for floating device.
[mi] miSpriteSetCursor called for floating device.

This creates a significant amount of log traffic in combination with XI2 button grabs on SDs.  I'm attaching a patch that was created by trial-and-error using gdb, but I am by no means claiming that this is the right way to go about it.

I've only tested this on 1.7.5, apologies if this has been fixed on master.
Comment 1 Tom Jaeger 2010-03-02 10:13:54 UTC
Created attachment 33691 [details] [review]
patch
Comment 2 Peter Hutterer 2010-03-08 20:55:33 UTC
hmm, i wonder if it would be easier to just remove the error messages - they don't really serve much purpose at this point (this is quite old code). it would have the benefit of making the caller's code easier to read too.
Comment 3 Tom Jaeger 2010-03-22 17:37:05 UTC
Sorry, I missed your comment somehow.  Removing the warnings sounds reasonable to me, but it's your call.
Comment 4 Peter Hutterer 2013-01-11 05:31:44 UTC
Claiming this is closed since I haven't seen this in a while. Please reopen if it's still here.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.