Bugzilla – Bug 26987
FBC not disabled when multiple displays are connected
Last modified: 2010-07-27 23:00:22 UTC
Created attachment 33911 [details]
dmesg when connect external disaplay before startx
Bug detailed description:
FBC should disabled when connect external display. But we find FBC is enabled if connect external display before startx. If connect external display after startx and then use command "xrandr --auto", FBC is disabled(this is right). This issue happens on 965gm and 915gm.
1.booting kernel with drm.debug=0x6
2.connect external display before starting X
Created attachment 33912 [details]
*** Bug 26989 has been marked as a duplicate of this bug. ***
Created attachment 36925 [details] [review]
disable fbc if multiple pipes are active
Can you give this patch a try? It should disable FBC if we try to enable more than one pipe.
Created attachment 36963 [details]
FBC is still enabled using this patch.
Ah, I see it only happens when the monitor is plugged in before X starts. I wonder if this is related to the DPMS bug I fixed recently. Can you try the patch in #28436 and see if it fixes the issue?
Created attachment 37032 [details]
I try the patch in #28436 and it still fails.
Created attachment 37343 [details] [review]
fixed multi-pipe disable patch
Last patch was missing the "goto out_disable" jump, so it wouldn't get disabled in the multi-pipe case.
Review of attachment 37343 [details] [review]:
Trying bz review for the first time, just to point out a couple of unrelated chunks.
On Fri, 23 Jul 2010 15:14:22 -0700 (PDT)
> --- Comment #8 from Chris Wilson <email@example.com> 2010-07-23 15:14:23 PDT ---
> Review of attachment 37343 [details] [review]:
> --> (https://bugs.freedesktop.org/review?bug=26987&attachment=37343)
> Trying bz review for the first time, just to point out a couple of unrelated
Yeah I didn't include those in the upstream submission. Thanks.
Works well with the patch.
author Jesse Barnes <firstname.lastname@example.org>
Fri, 23 Jul 2010 22:20:00 +0000 (15:20 -0700)
committer Eric Anholt <email@example.com>
Mon, 26 Jul 2010 18:27:06 +0000 (11:27 -0700)
tree 3d41bcee055ef9eec9e74eb98c4ac67cdcaba927 tree | snapshot
parent 127bd2ac91c3ecf42890ac320f4c65346d110e78 commit | diff
drm/i915: disable FBC when more than one pipe is active
We're really supposed to do this to avoid trouble with underflows when
multiple planes are active.
Signed-off-by: Jesse Barnes <firstname.lastname@example.org>
Tested-by: fangxun <email@example.com>
Signed-off-by: Eric Anholt <firstname.lastname@example.org>
Works fine with current tip. Mark it as verified.