Bugzilla – Bug 27417
[xv] corrupt output with textured video for certain width/height like 620x480
Last modified: 2010-04-08 11:24:13 UTC
Created attachment 34601 [details]
screenshot of the bug
Some H264 videos are completely corrupt when played back using textured video . I'm attaching a screenshot of the bug, and a short video which should be enough to reproduce the problem.
I think this is a regression, I will do some more testing and a bisect if possible.
-- chipset: G45 / ICH10R
-- system architecture: 32-bit
-- Linux distribution: Debian unstable
-- Machine or mobo model: Asus P5Q-EM
-- Display connector: DVI
-- xf86-video-intel: 440b4d207b730112169827d0b90b46596659b504
-- xserver: 188.8.131.522
-- mesa: 7e246e6aa63979d53731a591f4caee3651c1d96b
-- drm: cc20ed8100834b7a5129ed403dee6c0e15d82cd1
-- kernel: 184.108.40.206
Video which should reproduce the bug:
Did some more testing and this problem only happens for videos with a certain aspect ratio, file type doesn't matter.
The size of the video in the previous comment is 620 x 480, another video with the same problem is 700 x 576.
I can reproduce this issue on G45 just use the video you uploaded
As I suspected, this is a regression from 2.10.0, bisecting lead to this:
cb06aa32d433f54affe87da2cf964f0308d3c258 is the first bad commit
Author: Daniel Vetter <firstname.lastname@example.org>
Date: Mon Mar 1 22:57:39 2010 +0100
Xv: fixup XvMC on i915
I've accidentally broken i915 xvmc due to alignment constrains that
break my assumption that Y-pitch == UV-pitch*2. Fix this up by consistenly
using dstPitch2 for the Y-pitch. This also unifies the dst pitch
computation slightly, now that the i915 xvmc special case is gone.
Signed-off-by: Daniel Vetter <email@example.com>
(Minor edit to support compilation without INTEL_XVMC defined by
Carl Worth <firstname.lastname@example.org>)
:040000 040000 581e91ddb28f783bf765ea1259d4bcab9488ca75 dd733a90fcc54f47d26e811c416fbb61da888899 M src
*** Bug 27453 has been marked as a duplicate of this bug. ***
As mentioned in the duplicate bug, what matters is the *width* of the video.
Reverting the implicated commit resolves the issue.
Created attachment 34802 [details] [review]
fix chroma pitch on gen4 and later
Can you please test the attached patch?
The patch works for me, thanks!
Solves the issue here as well. Thanks.