Bug 27444 - Ship xproto.pc in $(datadir)/pkgconfig
Summary: Ship xproto.pc in $(datadir)/pkgconfig
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Build/Modular (show other bugs)
Version: git
Hardware: Other All
: low enhancement
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard: 2011BRB_Reviewed
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-03 16:06 UTC by Cyril Brulebois
Modified: 2018-06-12 19:23 UTC (History)
4 users (show)

See Also:
i915 platform:
i915 features:


Attachments
Proposed patch against git master (760 bytes, patch)
2010-04-03 16:08 UTC, Cyril Brulebois
no flags Details | Splinter Review

Description Cyril Brulebois 2010-04-03 16:06:54 UTC
It's been requested in Debian bug #550460 that xproto.pc be shipped under /usr/share/pkgconfig rather than /usr/lib/pkgconfig since: (1) there's nothing architecture-specific in there; and (2) it might break crosscompiling, or make it harder.

Reference: http://bugs.debian.org/550460
Comment 1 Cyril Brulebois 2010-04-03 16:08:11 UTC
Created attachment 34652 [details] [review]
Proposed patch against git master
Comment 2 Alan Coopersmith 2010-04-16 08:18:40 UTC
Assigning to Keith, who is in the middle of a complete overhaul of the
proto packages anyway.
Comment 3 Cyril Brulebois 2011-03-05 19:54:57 UTC
Keith, ACK/NACK? (The same would go for other proto packages.)

I don't really care either way, just wondering whether that's going to be merged at some point or closed WONTFIX (so that I can update the Debian bug accordingly).
Comment 4 Keith Packard 2011-03-05 21:32:53 UTC
Daniel has promised to merge the protocol packages together "real soon now". I don't have any opinion in this matter as I don't know why it matters.
Comment 5 Alan Coopersmith 2011-03-06 08:46:59 UTC
Since the proto merge has been delayed, why not just submit this patch to
xorg-devel so it gets reviewed & applied?    bugzilla is where patches go
to hide out for years unapplied and unloved.

Since this is effectively what I already do in building the Solaris X packages,
I'd agree to it, but only if we do it consistently for all the *proto.pc.
Comment 6 Jeremy Huddleston Sequoia 2011-10-09 03:13:40 UTC
yeah, this patch is correct, IMO and should be applied to all the protos.  
Gaetan has good batch-fu, so maybe he can tackle this... ? =)
Comment 7 Alan Coopersmith 2011-10-09 10:12:24 UTC
Just a note of caution:  Of all the protos, xproto is actually the exception 
and the one that's not completely platform independent, due to the configure
checks that substitute platform values into Xpoll.h.in and Xfuncproto.h.in.

For cross-compiling for other ISA's on the same kernel there shouldn't be any
issue, but if anyone tries cross-compiling for another OS, they'd want to look
closely at it.   (Though for almost all modern OS'es, the generated answers are
the same - darwin and cygwin are surprisingly missing though.)
Comment 8 Quentin "Sardem FF7" Glidic 2012-06-12 04:27:53 UTC
Any news on this issue?

I can provide patches for all the relevant repositories if needed.
Comment 9 Marc-Antoine Perennou 2012-10-01 15:52:04 UTC
Since nearly all x*protos are affected and it's kinda trivial and straightforward, would patches be accepted and pushed , as the one submitted... in 2010 ?
Comment 10 Alan Coopersmith 2012-10-02 02:47:42 UTC
(In reply to comment #9)
> Since nearly all x*protos are affected and it's kinda trivial and
> straightforward, would patches be accepted and pushed , as the one
> submitted... in 2010 ?

Hard to say, given the ongoing debate on whether this hurts cross-compiling
or not, as discussed on xorg-devel recently - see the thread
"Installing proto pc files in /usr/share/pkgconfig?" on
http://lists.x.org/archives/xorg-devel/2012-September/thread.html

If you'd like to see this happen, contributing to that discussion may help.
Comment 11 Adam Jackson 2018-06-12 19:23:13 UTC
xorgproto does this now.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.