Bug 27445 - Should set Initiator{ID,Handle} for other channel types
Summary: Should set Initiator{ID,Handle} for other channel types
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: butterfly (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Jonny Lamb
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/jo...
Whiteboard: review+
Keywords: patch
Depends on:
Blocks:
 
Reported: 2010-04-03 16:58 UTC by Jonny Lamb
Modified: 2010-05-21 06:58 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Jonny Lamb 2010-04-03 16:58:31 UTC 
At the moment, butterfly only sets the initiator properties for media channels. It should do this for all other channel types.

See my branch for a fix for this.
Comment 1 Jonny Lamb 2010-04-03 17:07:25 UTC 
For the record, I did try and put this into tp-python's Channel class at first, but unfortunately I couldn't get it working as the code needs to get the handle class from both the handle itself *and* the handle ID.
Comment 2 Simon McVittie 2010-04-13 07:37:49 UTC 
Drive-by review:

> +        # otherwise use InitiatorID.
> +        elif telepathy.CHANNEL_INTERFACE + '.InitiatorID' in props:
> +            self._initiator = ButterflyHandleFactory(conn, 'contact',
> +                id=props[telepathy.CHANNEL_INTERFACE + '.InitiatorHandle'])

s/InitiatorHandle/InitiatorID/
Comment 3 Jonny Lamb 2010-04-13 08:50:27 UTC 
(In reply to comment #2)
> s/InitiatorHandle/InitiatorID/

Ha, good catch. Fixed.
Comment 4 Olivier Le Thanh Duong 2010-05-21 06:58:14 UTC 
Merged, this fix is available in butterfly 0.5.10

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.