Bug 27467 - Update symbols/fi
Summary: Update symbols/fi
Alias: None
Product: xkeyboard-config
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: xkb
QA Contact:
Depends on:
Reported: 2010-04-05 05:53 UTC by Marko Myllynen
Modified: 2010-05-13 13:09 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Updated symbols/fi (12.88 KB, application/octet-stream)
2010-04-05 05:53 UTC, Marko Myllynen
clean up header (3.07 KB, text/plain)
2010-05-13 12:03 UTC, Marko Myllynen
add std header (3.04 KB, text/plain)
2010-05-13 12:05 UTC, Marko Myllynen
smi patch (1.02 KB, text/plain)
2010-05-13 12:06 UTC, Marko Myllynen
add new keys to classic variant (4.59 KB, text/plain)
2010-05-13 12:09 UTC, Marko Myllynen
sync nodeadkeys (790 bytes, text/plain)
2010-05-13 12:10 UTC, Marko Myllynen
sort classic (5.01 KB, text/plain)
2010-05-13 12:11 UTC, Marko Myllynen
whitespace issues (20.42 KB, text/plain)
2010-05-13 12:12 UTC, Marko Myllynen

Description Marko Myllynen 2010-04-05 05:53:30 UTC
Created attachment 34673 [details]
Updated symbols/fi

I'm attaching a slightly updated symbols/fi with the following changes:

- added header about the file itself as required by the standard SFS 5966, clean up old obsoleted comments
- (scripted) whitespace clean up
- added missing xkb_symbols header for the smi variant
- corrected name for Eliminate dead keys variant (it is a variant of Classic map not the default variant)
- added few sometimes used symbols from the default variant to Classic variant
- reorganized Classic variant to follow the default variant grouping
- no modifications to the default variant

Due to whitespace and line ordering changes a patch would be a bit hard to read so the new file is attached. If you want to inspect the changes in detail I suggest using 'diff -uw'.

I'm CC'ing Troy with whom I've already discussed about this update (and last time we talked he was ok with it).
Comment 1 Sergey V. Udaltsov 2010-05-05 16:23:45 UTC
Sorry, the difference between current version in git and your file is large enough. Could you please submit a patch instead - making sure that all changes are necessary?
Comment 2 Marko Myllynen 2010-05-13 12:00:23 UTC
Indeed, there were quite a few changes for a one go. I'll attach incremental patches that'll make it more clear what's going on. Please ask for clarifications if needed.
Comment 3 Marko Myllynen 2010-05-13 12:03:00 UTC
Created attachment 35630 [details]
clean up header

This patch just cleans up the file header.
Comment 4 Marko Myllynen 2010-05-13 12:05:01 UTC
Created attachment 35631 [details]
add std header

This patch adds the standard mandated definition of the default keymap. Add/remove some blank lines for readability, adjust keymap header to match other headers.
Comment 5 Marko Myllynen 2010-05-13 12:06:37 UTC
Created attachment 35632 [details]
smi patch

This patch adds the missing keymap header to the smi variant, corrects some comments and changes Ooblique->Oslash for consistency.
Comment 6 Marko Myllynen 2010-05-13 12:09:44 UTC
Created attachment 35633 [details]
add new keys to classic variant

This patch adds few new keys to the classic variant where feasible to make some features of the default keymap available also on the classic one. Adds missing compose include, uses include directive to map nbsp.
Comment 7 Marko Myllynen 2010-05-13 12:10:32 UTC
Created attachment 35634 [details]
sync nodeadkeys

This patch syncs the nodeadkeys variant after the previous changes.
Comment 8 Marko Myllynen 2010-05-13 12:11:49 UTC
Created attachment 35635 [details]
sort classic

This patch just sorts the key mappings in the classic map to be follow the ordering the default keymap. No changes to mappings.
Comment 9 Marko Myllynen 2010-05-13 12:12:55 UTC
Created attachment 35636 [details]
whitespace issues

Scripted whitespace clean up, zero changes to anything else which can be verified by running diff -w for the original and patched maps.
Comment 10 Sergey V. Udaltsov 2010-05-13 13:09:56 UTC
Thank you very much! Good timing, just before the release.

The patches are fine and easy to understand. I am just a bit surprised though they are not formatted as git commits.

Anyway, committed. Good that you settled that with Troy

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.