Wocky doesn't currently install any headers at all; Gabble installs all of them. It would be good to divide the headers into "will-be-public" and internal, in two separate variables or something, to make it easier to install the right ones; similarly, it would be good to prepend _ to the names of extern-but-protected functions. In a branch to fix the documentation, I've guessed that *-protected.h and wocky-pubsub-helpers.h are meant to be internal to the library.
(In reply to comment #0) > In a branch to fix the documentation, I've guessed that *-protected.h and > wocky-pubsub-helpers.h are meant to be internal to the library. In fact, they're intended to be public. Underscored functions like _wocky_pubsub_node_handle_event_stanza should probably be moved to a new wocky-pubsub-node-internal.h.
So how about this: http://cgit.collabora.com/git/user/wjt/wocky/log/?h=headers http://cgit.collabora.com/git/user/wjt/telepathy-gabble/log/?h=wocky-headers I cleared up the specific case mentioned here, and add a few #errors to internal-only headers, and grouped all public headers into #include <wocky/wocky.h>.
Yay! r+ I'd personally also rename heartbeat-source and http-proxy to end with -internal (or -private if you prefer). Your call.
(In reply to comment #3) > Yay! r+ > > I'd personally also rename heartbeat-source and http-proxy to end with > -internal (or -private if you prefer). Your call. I merged it as-is.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.