sometime ago I've posted a patch to avoid breaking compatibility with old windows while using GetSystemWindowsDirectoryA I've noticed the code was broken since the better place to place dynamic function loading is FcConfigParseAndLoad (hope it's finally ok here ;D) I'm attaching the updated patch
Created attachment 34778 [details] [review] proposed patch
Created attachment 34792 [details] [review] A better patch that integrates also LOCAL_APPDATA_FONTCONFIG_CACHE path
ah you need to replace strncat(szFPath, "\\MPlayer", MAX_PATH - 1 - strlen(szFPath)); with strncat(szFPath, "\\fontconfig\\cache", MAX_PATH - 1 - strlen(szFPath));
Gianluigi, please attach an updated patch. Tor, can you review this please? I'm going to make a release early next week, so the sooner you can review this the better.
Looks fine to me.
Tor, feel like testing and committing?
The attached patch seems not cleanly applied to current git repo. that would be appreciated if you can update.
Created attachment 59822 [details] [review] new patch updated patch
I've updated the patch trying to retain formatting/tabs where possible (broken in some places) I still don't have a way to test compatibility with old windows right now, I need to setup again my mplayer build environment I lost in a fs corruption, but technically the patch is just adapted so it should act as before (I've also fixed the mplayer reference)
sorry forgot to dos2unix
Thanks for the patch. fixed in 470e92c9
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.