From bug #27511 """ * You should be able to ask the Connection for its RequestableChannelClasses, as a Capabilities object (this is a feature in the sense of Bug #21097, IMO - perhaps TP_CONNECTION_FEATURE_CAPABILITIES) """
http://git.collabora.co.uk/?p=user/cassidy/telepathy-glib;a=shortlog;h=refs/heads/conn-caps-27618 This is based on my capabilities branch so bug #27511 should be reviewed first.
> + PROP_CAPABILIES, That's not how you spell capabilities. > + * The %TP_CAPABILITIES object representing the capabilities of this The #TpCapabilities object ... > + * To wait for a valid capabilities, call tp_proxy_prepare_async() with To wait for valid capability information, ... > + self->priv->capabilities = _tp_capabilities_new (g_value_get_boxed (value), You need to check that the GValue contains the right boxed type first. If it doesn't, consider the connection to have no capabilities, or make the capabilities feature fail, or something.
(In reply to comment #2) > > + PROP_CAPABILIES, > > That's not how you spell capabilities. Oops; fixed. > > + * The %TP_CAPABILITIES object representing the capabilities of this > > The #TpCapabilities object ... done. > > + * To wait for a valid capabilities, call tp_proxy_prepare_async() with > > To wait for valid capability information, ... fixed. > > + self->priv->capabilities = _tp_capabilities_new (g_value_get_boxed (value), > > You need to check that the GValue contains the right boxed type first. If it > doesn't, consider the connection to have no capabilities, or make the > capabilities feature fail, or something. Done.
Looks good to me.
Merged. Will be in 0.11.3
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.