Bug 27695 - Contact: should enable slow path only if interface is not in ContactAttributeInterfaces
Summary: Contact: should enable slow path only if interface is not in ContactAttribute...
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Guillaume Desmottes
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/ca...
Whiteboard: review+ with one change
Keywords: patch
Depends on:
Blocks:
 
Reported: 2010-04-16 07:36 UTC by Guillaume Desmottes
Modified: 2010-04-20 03:33 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Guillaume Desmottes 2010-04-16 07:36:44 UTC 
Currently we start the slow-path if the feature has not been set after GetContactAttributes has returned. We should rather only start it if the iface is not listed in ContactAttributeInterfaces.
Comment 2 Simon McVittie 2010-04-20 03:18:02 UTC 
I'd prefer the helper function to be called contacts_context_supports_iface. With that change, review+.
Comment 3 Guillaume Desmottes 2010-04-20 03:33:11 UTC 
I amend the commit and merged it. Will be in 0.11.3

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.