Bug 28146 - typo in drm_edid.c drm_dmt_modes table
Summary: typo in drm_edid.c drm_dmt_modes table
Status: RESOLVED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/other (show other bugs)
Version: XOrg git
Hardware: All All
: medium normal
Assignee: Default DRI bug account
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-17 10:06 UTC by Scott Bertilson
Modified: 2010-05-19 08:52 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
fix the clock (1.02 KB, patch)
2010-05-19 08:51 UTC, Alex Deucher 		no flags Details | Splinter Review
View All

Description Scott Bertilson 2010-05-17 10:06:39 UTC 
It has an extra 0 in the clock frequency for a 1600x1200 mode:

{ DRM_MODE("1600x1200", DRM_MODE_TYPE_DRIVER, 2025000, 1600, 1664,
           1856, 2160, 0, 1200, 1201, 1204, 1250, 0,
           DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },

Note clock specified as 2025000 rather than 202500.

Prevented xorg-server 1.8.0 from using this mode on a Dell D1226H I have under kernel 2.6.32 (Gentoo/Sabayon).

Bug still shows up in git.kernel.org: linux-next.git.

Tried to find in freedesktop repository, but couldn't seem to figure out how to get to it.  Should have read more, but hoping this isn't too inconvenient for you folks - i.e. that it hasn't already been fixed on your side.

Thanks.
Comment 1 Scott Bertilson 2010-05-17 12:10:12 UTC 
Fixing this and reloading the module allows the mode to be used.
Comment 2 Alex Deucher 2010-05-19 08:51:05 UTC 
Created attachment 35762 [details] [review]
fix the clock

Here's the patch I've sent upstream.
Comment 3 Alex Deucher 2010-05-19 08:52:31 UTC 
thanks for spotting this.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.