Bugzilla – Bug 282
Shape Extension spec lists incorrect opcodes
Last modified: 2004-03-14 23:55:11 UTC
The encoding section of the Shape Extension spec (xc/doc/specs/Xext/shape.ms)
incorrectly specifies the opcodes for the requests ShapeRequestInput and
ShapeRequestInput is shown as having the same opcode (6) as ShapeSelectInput.
It should really be 7, and that ShapeGetRectangles should have the opcode 8.
The correct values are shown in xc/include/extensions/shape.h .
(Originally reported to old X.org bug report address by Peter Liljenberg
in March 2002 and filed as X.org defect #9453.)
Whoops - copy and paste error - the above should actually say
"ShapeInputSelected" where it has "ShapeRequestInput"
Created attachment 135 [details] [review]
Proposed fix to shape spec
Sent proposed diffs to X.org Arch task force.
Looks fine to me except for the addition of the XdotOrg CVS tag. I think you
need to add a ':' or CVS will not substitute ($XdotOrg:$)?
The freedesktop.org CVS doesn't seem to require the : - it expands $Xdotorg$
The X.org architecture task force approved this as a trivial revision not
requiring public review since this is what everyone assumed the spec said
for the last 15 years.
Committed to XORG-RELEASE-1 branch:
40. Update SHAPE extension protocol spec to version 1.0.1, fixing
freedesktop.org bugzilla #282 (old X.org defect #9453) (Alan Coopersmith)
./: Tag: XORG-RELEASE-1
xc/doc/man/general/: Tag: XORG-RELEASE-1
xc/doc/specs/Xext/: Tag: XORG-RELEASE-1
xc/doc/hardcopy/Xext/: Tag: XORG-RELEASE-1
Revision Changes Path
22.214.171.124 +3 -1 xc/Attic/CHANGELOG-RELEASE-1
126.96.36.199 +2 -1 xc/doc/man/general/Standards.man
188.8.131.52 +16 -8 xc/doc/specs/Xext/shape.ms
184.108.40.206 +55 -64 xc/doc/hardcopy/Xext/shape.PS.gz
and to XORG-CURRENT branch:
25. Update SHAPE extension protocol spec to version 1.0.1, fixing
freedesktop.org bugzilla #282 (old X.org defect #9453)(Alan Coopersmith)
xc/doc/man/general/: Tag: XORG-CURRENT
xc/doc/specs/Xext/: Tag: XORG-CURRENT
xc/doc/hardcopy/Xext/: Tag: XORG-CURRENT
Revision Changes Path
220.127.116.11 +2 -1 xc/doc/man/general/Standards.man
18.104.22.168 +16 -8 xc/doc/specs/Xext/shape.ms
22.214.171.124 +55 -64 xc/doc/hardcopy/Xext/shape.PS.gz