The encoding section of the Shape Extension spec (xc/doc/specs/Xext/shape.ms) incorrectly specifies the opcodes for the requests ShapeRequestInput and ShapeGetRectangles. ShapeRequestInput is shown as having the same opcode (6) as ShapeSelectInput. It should really be 7, and that ShapeGetRectangles should have the opcode 8. The correct values are shown in xc/include/extensions/shape.h . (Originally reported to old X.org bug report address by Peter Liljenberg in March 2002 and filed as X.org defect #9453.)
Whoops - copy and paste error - the above should actually say "ShapeInputSelected" where it has "ShapeRequestInput"
Created attachment 135 [details] [review] Proposed fix to shape spec
Sent proposed diffs to X.org Arch task force.
Looks fine to me except for the addition of the XdotOrg CVS tag. I think you need to add a ':' or CVS will not substitute ($XdotOrg:$)?
The freedesktop.org CVS doesn't seem to require the : - it expands $Xdotorg$ without it. The X.org architecture task force approved this as a trivial revision not requiring public review since this is what everyone assumed the spec said for the last 15 years. Committed to XORG-RELEASE-1 branch: Log message: 40. Update SHAPE extension protocol spec to version 1.0.1, fixing freedesktop.org bugzilla #282 (old X.org defect #9453) (Alan Coopersmith) Modified files: ./: Tag: XORG-RELEASE-1 CHANGELOG-RELEASE-1 xc/doc/man/general/: Tag: XORG-RELEASE-1 Standards.man xc/doc/specs/Xext/: Tag: XORG-RELEASE-1 shape.ms xc/doc/hardcopy/Xext/: Tag: XORG-RELEASE-1 shape.PS.gz Revision Changes Path 1.1.2.23 +3 -1 xc/Attic/CHANGELOG-RELEASE-1 1.1.10.2 +2 -1 xc/doc/man/general/Standards.man 1.1.10.1 +16 -8 xc/doc/specs/Xext/shape.ms 1.1.10.1 +55 -64 xc/doc/hardcopy/Xext/shape.PS.gz and to XORG-CURRENT branch: Log message: 25. Update SHAPE extension protocol spec to version 1.0.1, fixing freedesktop.org bugzilla #282 (old X.org defect #9453)(Alan Coopersmith) Modified files: xc/doc/man/general/: Tag: XORG-CURRENT Standards.man xc/doc/specs/Xext/: Tag: XORG-CURRENT shape.ms xc/doc/hardcopy/Xext/: Tag: XORG-CURRENT shape.PS.gz Revision Changes Path 1.1.4.2 +2 -1 xc/doc/man/general/Standards.man 1.1.4.1 +16 -8 xc/doc/specs/Xext/shape.ms 1.1.4.1 +55 -64 xc/doc/hardcopy/Xext/shape.PS.gz
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.