Bug 28201 - refactor the roster, moving logic out of the channels into the roster itself
Summary: refactor the roster, moving logic out of the channels into the roster itself
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: git master
Hardware: Other All
: medium enhancement
Assignee: Will Thompson
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/sm...
Whiteboard: review+
Keywords: patch
Depends on:
Blocks: 28199
  Show dependency tree / graph
 
Reported: 2010-05-21 04:41 UTC by Simon McVittie
Modified: 2010-06-09 09:38 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Simon McVittie 2010-05-21 04:41:15 UTC 
Will apparently has some stale branches for this, which should be merged before we port to TpContactListManager (Bug #28199).
Comment 1 Simon McVittie 2010-06-02 11:32:04 UTC 
Will, any chance you could find these branches? If they're not ready for merge, I could pick them up - I'll have to do similar work for TpBaseContactList anyway.
Comment 2 Will Thompson 2010-06-02 11:37:01 UTC 
It's cunningly hidden at http://git.collabora.co.uk/?p=user/wjt/telepathy-gabble-wjt.git;a=shortlog;h=refs/heads/roster-sucks

It's against 0.8 but it probably shouldn't be.

"Don't leak an array of lol" could use a better commit message.

I though "Correctly default contacts on 'subscribe' to offline." had been merged already but apparently it was just languishing in git.
Comment 3 Simon McVittie 2010-06-09 09:34:21 UTC 
I separated some of the commits up to make the diffs reviewable. I'm now happy with the sanity of smcv/roster - are you? If so, I'll merge.
Comment 4 Will Thompson 2010-06-09 09:36:14 UTC 
looks fine!
Comment 5 Simon McVittie 2010-06-09 09:38:36 UTC 
Thanks, merged for 0.9.13.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.