Bug 28313 - Improve WebM/Matroska magic and add icons
Summary: Improve WebM/Matroska magic and add icons
Status: RESOLVED FIXED
Alias: None
Product: shared-mime-info
Classification: Unclassified
Component: freedesktop.org.xml (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Shared Mime Info group
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-29 06:17 UTC by Sebastian Dröge (slomo)
Modified: 2010-05-29 09:09 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
0001-Add-icons-to-several-Ogg-Matroska-WebM-types.patch (1.76 KB, patch)
2010-05-29 06:18 UTC, Sebastian Dröge (slomo)
Details | Splinter Review
0002-Add-audio-webm-mimetype.patch (899 bytes, patch)
2010-05-29 06:19 UTC, Sebastian Dröge (slomo)
Details | Splinter Review
0003-Improve-WebM-Matroska-magic.patch (1.65 KB, patch)
2010-05-29 06:20 UTC, Sebastian Dröge (slomo)
Details | Splinter Review
0001-Use-generic-video-icon-for-application-x-matroska.patch (811 bytes, patch)
2010-05-29 06:52 UTC, Sebastian Dröge (slomo)
Details | Splinter Review
0002-Add-audio-webm-mimetype.patch (899 bytes, patch)
2010-05-29 06:52 UTC, Sebastian Dröge (slomo)
Details | Splinter Review
0003-Improve-WebM-Matroska-magic.patch (1.64 KB, patch)
2010-05-29 06:52 UTC, Sebastian Dröge (slomo)
Details | Splinter Review
0002-Add-audio-webm-mimetype.patch (854 bytes, patch)
2010-05-29 06:54 UTC, Sebastian Dröge (slomo)
Details | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Dröge (slomo) 2010-05-29 06:17:35 UTC
Hi,
attached patches improve the WebM/Matroska magic and add relevant icons (to them and to the Ogg formats above, if you want I can split that patch). It also adds audio/webm as subclass of video/webm as specified by the WebM specification.

The rationale for the magic change is, that currently the magic is very restrictive and even fails to detect the WebM/Matroska files created by GStreamer.

With this magic it is checked if a) there's the valid EBML ID at the beginning, b) there's a DocumentType ID some bytes later and c) there's the recognized DocumentType (webm or matroska).
Comment 1 Sebastian Dröge (slomo) 2010-05-29 06:18:55 UTC
Created attachment 35935 [details] [review]
0001-Add-icons-to-several-Ogg-Matroska-WebM-types.patch
Comment 2 Sebastian Dröge (slomo) 2010-05-29 06:19:29 UTC
Created attachment 35936 [details] [review]
0002-Add-audio-webm-mimetype.patch
Comment 3 Sebastian Dröge (slomo) 2010-05-29 06:20:01 UTC
Created attachment 35937 [details] [review]
0003-Improve-WebM-Matroska-magic.patch
Comment 4 Bastien Nocera 2010-05-29 06:38:01 UTC
Comment on attachment 35935 [details] [review]
0001-Add-icons-to-several-Ogg-Matroska-WebM-types.patch

audio/ and video/ mime-types already have automatic fallback for generic icons, so this is unneeded.
Comment 5 Bastien Nocera 2010-05-29 06:39:41 UTC
Could you please respin the 2 patches and ensure that the test suite still passes?
Comment 6 Pino Toscano 2010-05-29 06:42:05 UTC
(In reply to comment #4)
> (From update of attachment 35935 [details] [review])
> audio/ and video/ mime-types already have automatic fallback for generic icons,
> so this is unneeded.

The video-x-generic fallback for application/x-matroska is not automatic though.
Comment 7 Sebastian Dröge (slomo) 2010-05-29 06:52:13 UTC
Created attachment 35938 [details] [review]
0001-Use-generic-video-icon-for-application-x-matroska.patch
Comment 8 Sebastian Dröge (slomo) 2010-05-29 06:52:38 UTC
Created attachment 35939 [details] [review]
0002-Add-audio-webm-mimetype.patch
Comment 9 Sebastian Dröge (slomo) 2010-05-29 06:52:54 UTC
Created attachment 35940 [details] [review]
0003-Improve-WebM-Matroska-magic.patch
Comment 10 Sebastian Dröge (slomo) 2010-05-29 06:54:37 UTC
Created attachment 35942 [details] [review]
0002-Add-audio-webm-mimetype.patch
Comment 11 Sebastian Dröge (slomo) 2010-05-29 06:57:38 UTC
"make check" passes with these patches
Comment 12 Bastien Nocera 2010-05-29 09:09:40 UTC
commit 9f0d0ff33d14dbc434b38744464318f0acca7037
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Sat May 29 15:10:28 2010 +0200

    Improve WebM/Matroska magic
    
    https://bugs.freedesktop.org/show_bug.cgi?id=28313

commit afcc2ef146dec94fd481960bb466a8f62ab6362c
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Sat May 29 14:45:28 2010 +0200

    Add audio/webm mimetype
    
    https://bugs.freedesktop.org/show_bug.cgi?id=28313

commit 14e58987db079b5fe00b6c4b910d3323a7ab31d7
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Sat May 29 14:42:43 2010 +0200

    Use generic video icon for application/x-matroska
    
    https://bugs.freedesktop.org/show_bug.cgi?id=28313


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.