Hi, attached patches improve the WebM/Matroska magic and add relevant icons (to them and to the Ogg formats above, if you want I can split that patch). It also adds audio/webm as subclass of video/webm as specified by the WebM specification. The rationale for the magic change is, that currently the magic is very restrictive and even fails to detect the WebM/Matroska files created by GStreamer. With this magic it is checked if a) there's the valid EBML ID at the beginning, b) there's a DocumentType ID some bytes later and c) there's the recognized DocumentType (webm or matroska).
Created attachment 35935 [details] [review] 0001-Add-icons-to-several-Ogg-Matroska-WebM-types.patch
Created attachment 35936 [details] [review] 0002-Add-audio-webm-mimetype.patch
Created attachment 35937 [details] [review] 0003-Improve-WebM-Matroska-magic.patch
Comment on attachment 35935 [details] [review] 0001-Add-icons-to-several-Ogg-Matroska-WebM-types.patch audio/ and video/ mime-types already have automatic fallback for generic icons, so this is unneeded.
Could you please respin the 2 patches and ensure that the test suite still passes?
(In reply to comment #4) > (From update of attachment 35935 [details] [review]) > audio/ and video/ mime-types already have automatic fallback for generic icons, > so this is unneeded. The video-x-generic fallback for application/x-matroska is not automatic though.
Created attachment 35938 [details] [review] 0001-Use-generic-video-icon-for-application-x-matroska.patch
Created attachment 35939 [details] [review] 0002-Add-audio-webm-mimetype.patch
Created attachment 35940 [details] [review] 0003-Improve-WebM-Matroska-magic.patch
Created attachment 35942 [details] [review] 0002-Add-audio-webm-mimetype.patch
"make check" passes with these patches
commit 9f0d0ff33d14dbc434b38744464318f0acca7037 Author: Sebastian Dröge <sebastian.droege@collabora.co.uk> Date: Sat May 29 15:10:28 2010 +0200 Improve WebM/Matroska magic https://bugs.freedesktop.org/show_bug.cgi?id=28313 commit afcc2ef146dec94fd481960bb466a8f62ab6362c Author: Sebastian Dröge <sebastian.droege@collabora.co.uk> Date: Sat May 29 14:45:28 2010 +0200 Add audio/webm mimetype https://bugs.freedesktop.org/show_bug.cgi?id=28313 commit 14e58987db079b5fe00b6c4b910d3323a7ab31d7 Author: Sebastian Dröge <sebastian.droege@collabora.co.uk> Date: Sat May 29 14:42:43 2010 +0200 Use generic video icon for application/x-matroska https://bugs.freedesktop.org/show_bug.cgi?id=28313
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.