Bug 28321 - Compiling fails if vala has not been installed
Summary: Compiling fails if vala has not been installed
Status: RESOLVED WONTFIX
Alias: None
Product: systemd
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Lennart Poettering
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-30 04:10 UTC by Christian Ruppert
Modified: 2010-06-02 11:41 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Makefile.am.patch (754 bytes, application/octet-stream)
2010-05-30 04:10 UTC, Christian Ruppert
Details

Description Christian Ruppert 2010-05-30 04:10:01 UTC
Created attachment 35952 [details]
Makefile.am.patch

Makefile:5003: warning: overriding commands for target `src/systemd-interfaces.c'
Makefile:4990: warning: ignoring old commands for target `src/systemd-interfaces.c'
(CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/sh /home/idle/dev/systemd/missing --run autoheader)
rm -f stamp-h1
touch config.h.in
cd . && /bin/sh ./config.status config.h
config.status: creating config.h
config.status: config.h is unchanged
make  all-am
make[1]: Entering directory `/home/idle/dev/systemd'
Makefile:5003: warning: overriding commands for target `src/systemd-interfaces.c'
Makefile:4990: warning: ignoring old commands for target `src/systemd-interfaces.c'
  VALAC  systemctl_vala.stamp
/bin/sh: -g: command not found
make[1]: *** [systemctl_vala.stamp] Error 127
make[1]: Leaving directory `/home/idle/dev/systemd'
make: *** [all] Error 2
Comment 1 Lennart Poettering 2010-06-02 07:48:15 UTC
If you build from git you need vala installed. The tarball includes pre-built .c files for the vala sources, and hence won't need vala around. the configure script will only check dependencies for tarball builds.
Comment 2 Christian Ruppert 2010-06-02 11:41:51 UTC
(In reply to comment #1)
> If you build from git you need vala installed. The tarball includes pre-built
> .c files for the vala sources, and hence won't need vala around. the configure
> script will only check dependencies for tarball builds.

For what is the "--disable-gtk" flag then?
Also the "HAVE_VALAC" statement in Makefile.am might be removed if vala is required during build.
That happens in case of "--disable-gtk" + vala installed:

src/systemadm.vala:20.7-20.9: error: The namespace name `Gtk' could not be found
using Gtk;
      ^^^
src/systemadm.vala:23.7-23.11: error: The namespace name `Pango' could not be found
using Pango;
      ^^^^^
src/systemadm.vala:27.26-27.30: error: The type name `Label' could not be found
public class LeftLabel : Label {
                         ^^^^^
src/systemadm.vala:36.27-36.31: error: The type name `Label' could not be found
public class RightLabel : Label {
                          ^^^^^
src/systemadm.vala:59.27-59.32: error: The type name `Window' could not be found
public class MainWindow : Window {
                          ^^^^^^
src/systemadm.vala:64.17-64.24: error: The type name `TreeView' could not be found
        private TreeView unit_view;
                ^^^^^^^^
src/systemadm.vala:65.17-65.24: error: The type name `TreeView' could not be found
        private TreeView job_view;
                ^^^^^^^^
src/systemadm.vala:67.17-67.25: error: The type name `ListStore' could not be found
        private ListStore unit_model;
                ^^^^^^^^^
src/systemadm.vala:68.17-68.25: error: The type name `ListStore' could not be found
        private ListStore job_model;
                ^^^^^^^^^
src/systemadm.vala:70.17-70.22: error: The type name `Button' could not be found
        private Button start_button;
                ^^^^^^
src/systemadm.vala:71.17-71.22: error: The type name `Button' could not be found
        private Button stop_button;
                ^^^^^^
src/systemadm.vala:72.17-72.22: error: The type name `Button' could not be found
        private Button restart_button;
                ^^^^^^
src/systemadm.vala:73.17-73.22: error: The type name `Button' could not be found
        private Button reload_button;
                ^^^^^^
src/systemadm.vala:74.17-74.22: error: The type name `Button' could not be found
        private Button cancel_button;
                ^^^^^^
src/systemadm.vala:76.17-76.21: error: The type name `Entry' could not be found
        private Entry unit_load_entry;
                ^^^^^
src/systemadm.vala:77.17-77.22: error: The type name `Button' could not be found
        private Button unit_load_button;
                ^^^^^^
src/systemadm.vala:79.17-79.22: error: The type name `Button' could not be found
        private Button server_snapshot_button;
                ^^^^^^
src/systemadm.vala:80.17-80.22: error: The type name `Button' could not be found
        private Button server_reload_button;
                ^^^^^^
src/systemadm.vala:103.17-103.24: error: The type name `ComboBox' could not be found
        private ComboBox unit_type_combo_box;
                ^^^^^^^^
src/systemadm.vala:112.17-112.24: error: The type name `Notebook' could not be found
                Notebook notebook = new Notebook();
                ^^^^^^^^
src/systemadm.vala:115.17-115.19: error: The type name `Box' could not be found
                Box unit_vbox = new VBox(false, 12);
                ^^^
src/systemadm.vala:119.17-119.19: error: The type name `Box' could not be found
                Box job_vbox = new VBox(false, 12);
                ^^^
src/systemadm.vala:124.17-124.19: error: The type name `Box' could not be found
                Box type_hbox = new HBox(false, 6);
                ^^^
src/systemadm.vala:148.17-148.19: error: The type name `Box' could not be found
                Box unit_load_hbox = new HBox(false, 6);
                ^^^
src/systemadm.vala:165.17-165.31: error: The type name `TreeModelFilter' could not be found
                TreeModelFilter unit_model_filter;
                ^^^^^^^^^^^^^^^
src/systemadm.vala:186.17-186.30: error: The type name `ScrolledWindow' could not be found
                ScrolledWindow scroll = new ScrolledWindow(null, null);
                ^^^^^^^^^^^^^^
src/systemadm.vala:222.17-222.21: error: The type name `Table' could not be found
                Table unit_table = new Table(8, 6, false);
                ^^^^^
src/systemadm.vala:227.17-227.21: error: The type name `Table' could not be found
                Table job_table = new Table(2, 2, false);
                ^^^^^
src/systemadm.vala:269.17-269.25: error: The type name `ButtonBox' could not be found
                ButtonBox bbox = new HButtonBox();
                ^^^^^^^^^
src/systemadm.vala:326.25-326.32: error: The type name `TreeIter' could not be found
                        TreeIter iter;
                        ^^^^^^^^
src/systemadm.vala:353.25-353.32: error: The type name `TreeIter' could not be found
                        TreeIter iter;
                        ^^^^^^^^
src/systemadm.vala:374.17-374.24: error: The type name `TreePath' could not be found
                TreePath p;
                ^^^^^^^^
src/systemadm.vala:380.17-380.25: error: The type name `TreeModel' could not be found
                TreeModel model = unit_view.get_model();
                ^^^^^^^^^
src/systemadm.vala:381.17-381.24: error: The type name `TreeIter' could not be found
                TreeIter iter;
                ^^^^^^^^
src/systemadm.vala:540.17-540.24: error: The type name `TreePath' could not be found
                TreePath p;
                ^^^^^^^^
src/systemadm.vala:546.17-546.24: error: The type name `TreeIter' could not be found
                TreeIter iter;
                ^^^^^^^^
src/systemadm.vala:547.17-547.25: error: The type name `TreeModel' could not be found
                TreeModel model = job_view.get_model();
                ^^^^^^^^^
src/systemadm.vala:650.38-650.45: error: The type name `TreeIter' could not be found
        public void update_unit_iter(TreeIter iter, string id, Unit u) {
                                     ^^^^^^^^
src/systemadm.vala:682.17-682.24: error: The type name `TreeIter' could not be found
                TreeIter iter;
                ^^^^^^^^
src/systemadm.vala:687.37-687.44: error: The type name `TreeIter' could not be found
        public void update_job_iter(TreeIter iter, uint32 id, Job j) {
                                    ^^^^^^^^
src/systemadm.vala:705.17-705.24: error: The type name `TreeIter' could not be found
                TreeIter iter;
                ^^^^^^^^
src/systemadm.vala:711.17-711.24: error: The type name `TreeIter' could not be found
                TreeIter iter;
                ^^^^^^^^
src/systemadm.vala:732.17-732.24: error: The type name `TreeIter' could not be found
                TreeIter iter;
                ^^^^^^^^
src/systemadm.vala:754.17-754.24: error: The type name `TreeIter' could not be found
                TreeIter iter;
                ^^^^^^^^
src/systemadm.vala:780.17-780.24: error: The type name `TreeIter' could not be found
                TreeIter iter;
                ^^^^^^^^
src/systemadm.vala:805.33-805.41: error: The type name `TreeModel' could not be found
        public bool unit_filter(TreeModel model, TreeIter iter) {
                                ^^^^^^^^^
src/systemadm.vala:805.50-805.57: error: The type name `TreeIter' could not be found
        public bool unit_filter(TreeModel model, TreeIter iter) {
                                                 ^^^^^^^^
src/systemadm.vala:847.42-847.56: error: The type name `TreeModelFilter' could not be found
                TreeModelFilter model = (TreeModelFilter) unit_view.get_model();
                                         ^^^^^^^^^^^^^^^
src/systemadm.vala:847.17-847.31: error: The type name `TreeModelFilter' could not be found
                TreeModelFilter model = (TreeModelFilter) unit_view.get_model();
                ^^^^^^^^^^^^^^^
Compilation failed: 49 error(s), 0 warning(s)
make[1]: *** [systemadm_vala.stamp] Error 1
make[1]: *** Waiting for unfinished jobs....

At least systemadm.vala should be excluded if --disable-gtk has been defined.


The following is usually a "new bug" but I'll post it here for now anyway...
I also noticed a few things that should be fixed as well:
systemadm.vala:302: warning: implicit declaration of function ‘manager_dbus_proxy_new’ [-Wimplicit-function-declaration]
systemadm.vala:328: warning: implicit declaration of function ‘unit_dbus_proxy_new’ [-Wimplicit-function-declaration]
systemadm.vala:355: warning: implicit declaration of function ‘job_dbus_proxy_new’ [-Wimplicit-function-declaration]
systemctl.vala:58: warning: implicit declaration of function ‘unit_dbus_proxy_new’ [-Wimplicit-function-declaration]
systemctl.vala:76: warning: implicit declaration of function ‘job_dbus_proxy_new’ [-Wimplicit-function-declaration]
systemctl.vala:155: warning: implicit declaration of function ‘manager_dbus_proxy_new’ [-Wimplicit-function-declaration]

Function `manager_dbus_proxy_new' implicitly converted to pointer at systemadm.vala:302
Function `unit_dbus_proxy_new' implicitly converted to pointer at systemadm.vala:328
Function `job_dbus_proxy_new' implicitly converted to pointer at systemadm.vala:355
Function `unit_dbus_proxy_new' implicitly converted to pointer at systemctl.vala:58
Function `job_dbus_proxy_new' implicitly converted to pointer at systemctl.vala:76
Function `manager_dbus_proxy_new' implicitly converted to pointer at systemctl.vala:155

There are more warnings but IMHO they're the most important...


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.