Bug 28381 - rv670 + tiling patches + tiling enabled = parse errors on some demos.
Summary: rv670 + tiling patches + tiling enabled = parse errors on some demos.
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/R600 (show other bugs)
Version: git
Hardware: x86 (IA32) Linux (All)
: medium normal
Assignee: Default DRI bug account
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-04 03:43 UTC by Andy Furniss
Modified: 2010-09-02 06:17 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
cs parser fix (533 bytes, patch)
2010-06-04 15:37 UTC, Alex Deucher
Details | Splinter Review

Description Andy Furniss 2010-06-04 03:43:05 UTC
Running drt + patch that fixes https://bugs.freedesktop.org/show_bug.cgi?id=28327.

Patched Mesa and ddx for tiling and did some testing - I can't reproduce

https://bugs.freedesktop.org/show_bug.cgi?id=28342

but if I enable tiling in xorg.conf I get parse errors with some demos, but not others.

eg [glx]gears will quit with drmRadeonCmdBuffer: -22. Kernel failed to parse or rejected command stream, dmesg =

radeon 0000:02:00.0: r600_cs_track_validate_cb:216 cb height (306) invalid
radeon 0000:02:00.0: r600_packet3_check:1245 invalid cmd stream 520
[drm:radeon_cs_ioctl] *ERROR* Invalid command stream !

Other demos eg gloss, cubemap shadowtex also fail 
but others work OK eg.
morph3d, tunnel, geartrain, openarena, nexuiz and mplayer -vo gl.

I tried the ddx patch that fixes the cold boot bug above, but it doesn't help.
Comment 1 Alex Deucher 2010-06-04 15:37:44 UTC
Created attachment 36064 [details] [review]
cs parser fix

This patch fixes it here.
Comment 2 Andy Furniss 2010-06-05 03:56:40 UTC
(In reply to comment #1)
> Created an attachment (id=36064) [details]
> cs parser fix
> 
> This patch fixes it here.

cubemap & lodbias are not fixed -

radeon 0000:02:00.0: r600_cs_track_validate_cb offset[0] 384 too big
radeon 0000:02:00.0: r600_packet3_check:1247 invalid cmd stream 535
[drm:radeon_cs_ioctl] *ERROR* Invalid command stream !
Comment 3 Andy Furniss 2010-06-15 08:15:46 UTC
(In reply to comment #2)

> cubemap & lodbias are not fixed -

It seems that cubemap may not be related to tiling.

If I revert the mesa & ddx patches then running current patched d-r-t it still fails as above, but if I run a d-r-t from 20th May then it still fails with

cubemap: radeon_mipmap_tree.c:472: migrate_image_to_miptree: Assertion `srclvl->size == dstlvl->size' failed.

lodbias however does work with 20th May d-r-t, but fails running current patched d-r-t, unpatched mesa/ddx -

radeon 0000:02:00.0: r600_cs_track_validate_cb offset[0] 1024 too big
radeon 0000:02:00.0: r600_packet3_check:1247 invalid cmd stream 539
Comment 4 Andy Furniss 2010-06-18 13:53:07 UTC
(In reply to comment #3)

> If I revert the mesa & ddx patches then running current patched d-r-t

Another issue I have noticed running like this is that scrolling in seamonkey is more laggy than with a previous unpatched/no tiling d-r-t.

It's not bad enough to notice using mouse wheel, but if I grab the scroll bar and try to scroll fast it's noticeable. Just a long text page like an fdo bug report will show it.
Comment 5 Andy Furniss 2010-06-20 07:08:04 UTC
(In reply to comment #4)
> (In reply to comment #3)
> 
> > If I revert the mesa & ddx patches then running current patched d-r-t
> 
> Another issue I have noticed running like this is that scrolling in seamonkey
> is more laggy than with a previous unpatched/no tiling d-r-t.
> 
> It's not bad enough to notice using mouse wheel, but if I grab the scroll bar
> and try to scroll fast it's noticeable. Just a long text page like an fdo bug
> report will show it.

Looks like the above may not be related to kernel with tiling after all, although d-r-t without tiling is better it is still not as good as if I revert ddx a bit to remove the last few r6xx commits.

ddx reset to 5f093357f18eb9bea641394ab86a92a1766d8f2e unpatched works perfectly wrt scrolling with current d-r-t + patches.
Comment 6 Andy Furniss 2010-06-20 13:27:04 UTC
(In reply to comment #5)

> > Another issue I have noticed running like this is that scrolling in seamonkey
> > is more laggy than with a previous unpatched/no tiling d-r-t.

 I've found the ddx commit that caused this and filed a bug

https://bugs.freedesktop.org/show_bug.cgi?id=28629
Comment 7 Andy Furniss 2010-09-02 06:17:14 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > Created an attachment (id=36064) [details] [details]
> > cs parser fix
> > 
> > This patch fixes it here.
> 
> cubemap & lodbias are not fixed -
> 
> radeon 0000:02:00.0: r600_cs_track_validate_cb offset[0] 384 too big
> radeon 0000:02:00.0: r600_packet3_check:1247 invalid cmd stream 535
> [drm:radeon_cs_ioctl] *ERROR* Invalid command stream !

Closing as these work for me now (although I am using different hardware)


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.