Bug 28634 - missing TV parameter "Flicker Filter"
Summary: missing TV parameter "Flicker Filter"
Status: CLOSED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: unspecified
Hardware: All All
: medium enhancement
Assignee: Chris Wilson
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-20 19:54 UTC by Gordon Jin
Modified: 2017-09-04 10:01 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Gordon Jin 2010-06-20 19:54:27 UTC
"Flicker Filter" is not implemented in the driver.

Below is the SDVO-TV output of "xrandr --verbose", with ADD2 card on G45, with 2.6.34 kernel:

TV1 unknown connection 1024x768+0+0 (0x44) normal (normal left inverted right x axis y axis) 0mm x 0mm
	Identifier: 0x43
	Timestamp:  201719
	Subpixel:   horizontal rgb
	Gamma:      1.0:1.0:1.0
	Brightness: 1.0
	Clones:    
	CRTC:       0
	CRTCs:      0 1
	Transform:  1.000000 0.000000 0.000000
	            0.000000 1.000000 0.000000
	            0.000000 0.000000 1.000000
	           filter: 
	brightness: 128 (0x00000080)	range:  (0,255)
	hue: 64 (0x00000040)	range:  (0,127)
	contrast: 64 (0x00000040)	range:  (0,127)
	saturation: 69 (0x00000045)	range:  (0,127)
	vpos: 512 (0x00000200)	range:  (0,1023)
	hpos: 512 (0x00000200)	range:  (0,1023)
	bottom_margin: 15 (0x0000000f)	range:  (0,47)
	top_margin: 15 (0x0000000f)	range:  (0,47)
	right_margin: 15 (0x0000000f)	range:  (0,47)
	left_margin: 15 (0x0000000f)	range:  (0,47)
	mode:	NTSC_M
		supported: NTSC_M       NTSC_J       NTSC_443     PAL_B       
		           PAL_D        PAL_G        PAL_H        PAL_I       
		           PAL_M        PAL_N        PAL_NC       PAL_60      
		           SECAM_B      SECAM_D      SECAM_G      SECAM_K     
		           SECAM_K1     SECAM_L      SECAM_60    
  1024x768 (0x44)   65.0MHz -HSync -VSync *current
        h: width  1024 start 1048 end 1184 total 1344 skew    0 clock   48.4KHz
        v: height  768 start  771 end  777 total  806           clock   60.0Hz
  800x600 (0x45)   40.0MHz +HSync +VSync
        h: width   800 start  840 end  968 total 1056 skew    0 clock   37.9KHz
        v: height  600 start  601 end  605 total  628           clock   60.3Hz
  800x600 (0x46)   36.0MHz +HSync +VSync
        h: width   800 start  824 end  896 total 1024 skew    0 clock   35.2KHz
        v: height  600 start  601 end  603 total  625           clock   56.2Hz
  848x480 (0x47)   33.8MHz +HSync +VSync
        h: width   848 start  864 end  976 total 1088 skew    0 clock   31.0KHz
        v: height  480 start  486 end  494 total  517           clock   60.0Hz
  640x480 (0x48)   25.2MHz -HSync -VSync
        h: width   640 start  656 end  752 total  800 skew    0 clock   31.5KHz
        v: height  480 start  489 end  492 total  525           clock   59.9Hz
  640x480 (0x49)   25.2MHz -HSync -VSync
        h: width   640 start  656 end  752 total  800 skew    0 clock   31.5KHz
        v: height  480 start  490 end  492 total  525           clock   59.9Hz
Comment 1 Chris Wilson 2010-07-18 11:29:18 UTC
I've written a patch to add the missing filters:

  flicker filter,
  flicker filter adaptive,
  flicker filter 2d,
  TV chroma filter,
  TV luma filter

and

  sharpness.


 drivers/gpu/drm/i915/intel_sdvo.c      |  604 ++++++++++++++------------------
 drivers/gpu/drm/i915/intel_sdvo_regs.h |   48 ++--
 2 files changed, 287 insertions(+), 365 deletions(-)

However, it is based on my tree with various changes to sdvo outstanding...
Comment 2 Chris Wilson 2010-08-06 15:07:21 UTC
Applied to Eric's for-linus branch.
Comment 3 madbiologist 2010-08-24 00:06:09 UTC
The abovementioned patch is included in kernel 2.6.36-rc2.
Comment 4 bo.b.wang 2011-06-07 22:19:11 UTC
test on commit  2.6.36-rc2 and it works well.
Tested-by: wang bo bo.b.wang@intel.com
Comment 5 Jari Tahvanainen 2017-09-04 10:01:08 UTC
Closing old verified+fixed.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.