Each time a message is logged, a new TpAccount is created and to the Account property are fetched by tp-glib. We should reuse the existing TpAccount instead.
http://git.collabora.co.uk/?p=user/cassidy/telepathy-logger;a=shortlog;h=refs/heads/account-28682
> +#include <telepathy-glib/account.h> > #include <telepathy-glib/util.h> Might as well be <telepathy-glib/telepathy-glib.h>? (This applies to entry.[ch].) > + * Returns: the path as the #TplEntry:account property "...: the object path of the #..." Also, if you add "<!-- no more to say -->" as the "body" of the doc-comment for every method whose "Returns:" is enough documentation, gtk-doc will consider it to be documented, and shut up. This will be useful when we try to get Tpl fully-documented. > + * tpl_entry_get_account Similarly, add "<!-- no more to say -->".
(In reply to comment #2) > > +#include <telepathy-glib/account.h> > > #include <telepathy-glib/util.h> > > Might as well be <telepathy-glib/telepathy-glib.h>? (This applies to > entry.[ch].) done. > > + * Returns: the path as the #TplEntry:account property > > "...: the object path of the #..." > > Also, if you add "<!-- no more to say -->" as the "body" of the doc-comment for > every method whose "Returns:" is enough documentation, gtk-doc will consider it > to be documented, and shut up. This will be useful when we try to get Tpl > fully-documented. > > > + * tpl_entry_get_account > > Similarly, add "<!-- no more to say -->". done (I amend the commits).
Merged.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.