Bug 28777 - Improve cross-compiling in xorg-server.m4
Summary: Improve cross-compiling in xorg-server.m4
Status: RESOLVED INVALID
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-27 03:31 UTC by Enrico Scholz
Modified: 2018-06-12 18:44 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Improve cross-compiling in xorg-server.m4 (632 bytes, patch)
2010-06-27 03:31 UTC, Enrico Scholz
no flags Details | Splinter Review

Description Enrico Scholz 2010-06-27 03:31:31 UTC
Created attachment 36541 [details] [review]
Improve cross-compiling in xorg-server.m4

The XORG_DRIVER_CHECK_EXT macro in xorg-server.m4 contains

| CFLAGS="$CFLAGS -I`$PKG_CONFIG --variable=sdkdir xorg-server`"

There are various ways how 'sdkdir' expands in cross environments; in OpenEmbedded, it and the other variables like prefix expand to their native paths (e.g. /usr/include/xorg) and will inject host paths into the CFLAGS hence resp. use host information in the checks.

It would be better to handle it similarly to --cflags operations by prepending PKG_CONFIG_SYSROOT_DIR to directory names; e.g. write above as 

| CFLAGS="$CFLAGS -I$PKG_CONFIG_SYSROOT_DIR`$PKG_CONFIG --variable=sdkdir xorg-server`"
 	

Attached patch does this but needs a hack because PKG_CONFIG_SYSROOT_DIR is a forbidden macro (see bug #28776).
Comment 1 Adam Jackson 2018-06-12 18:44:18 UTC
Mass closure: This bug has been untouched for more than six years, and is not obviously still valid. Please file a new report if you continue to experience issues with a current server.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.