Created attachment 36606 [details] Incorrect behaviour Using the latest (29/June/2010) development client with the stable v0.4 server, sometimes the video streams seem to have the blue and red channels inverted.
Created attachment 36607 [details] Correct behaviour
There are two issues here. The old code that converted from rgb to yuv for conversion to jpeg had two bugs: 1) It swapped the red and blue channels. It reswapped it in the old client so it wasn't a problem there, but the yuv values were not quite right which could cause worse compression. This should be easy to fix in the new client by just swapping if peer_major is 1 2) It converted to the "traditional" yuv where y goes from 16-235 (PIX_FMT_YUV420P in ffmpeg), but jpeg uses the "full" YUV version where y goes from 0-255 (PIX_FMT_YUVJ420P in ffmpeg). This means that if you decode such a file correctly (assuming the full y range) the intensity will look kinda compress towards the middle intensity. This might be kinda hard to undo without being slow...
I fixed the channel swapping, the luminocity still needs fixing
I haven't seen that luminocity problem in 0.8 components. Does still it need to be fixed?
Server major 1 is the 0.4 version of the protocol, i.e. when you use 0.6/0.8 to talk to a 0.4 server. So, this will not be visible in pure 0.8 setups.
spicec is deprecated. If you hit this bug, we highly recommended virt-viewer http://virt-manager.org/download/ http://www.spice-space.org/download.html
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.