Bug 2893 - Fix Vector extensions usage for GCC4 in fbmmx.
Summary: Fix Vector extensions usage for GCC4 in fbmmx.
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: 6.8.2
Hardware: Other Linux (All)
: high normal
Assignee: Xorg Project Team
QA Contact:
URL:
Whiteboard:
Keywords:
: 2465 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-04-03 22:55 UTC by Stefan Dirsch
Modified: 2005-04-17 05:55 UTC (History)
4 users (show)

See Also:
i915 platform:
i915 features:


Attachments
intrinsics-gcc4.patch (1.02 KB, patch)
2005-04-03 22:56 UTC, Stefan Dirsch
roland.mainz: 6.8-branch?
Details | Splinter Review
A different patch (4.11 KB, patch)
2005-04-04 10:09 UTC, Søren Sandmann Pedersen
soren.sandmann: 6.8-branch?
Details | Splinter Review

Description Stefan Dirsch 2005-04-03 22:55:48 UTC
I'll attach a patch, which fixes Vector extensions usage for GCC4 in fbmmx. 
The patch is by Andreas Jaeger <aj@suse.de>.
Comment 1 Stefan Dirsch 2005-04-03 22:56:57 UTC
Created attachment 2305 [details] [review]
intrinsics-gcc4.patch
Comment 2 Egbert Eich 2005-04-04 03:21:07 UTC
Not required for HEAD.
Comment 3 Egbert Eich 2005-04-04 03:21:56 UTC
Comment on attachment 2305 [details] [review]
intrinsics-gcc4.patch

Maybe this would be something for the next bugfix release.
Comment 4 Søren Sandmann Pedersen 2005-04-04 10:09:38 UTC
Created attachment 2316 [details] [review]
A different patch

This patch is not conditionalized on gcc4
Comment 5 Roland Mainz 2005-04-04 10:43:28 UTC
Comment on attachment 2305 [details] [review]
intrinsics-gcc4.patch

Setting "approval_X11R6.8.x"-flag to "request approval"(='?') ...
Comment 6 Søren Sandmann Pedersen 2005-04-15 10:50:21 UTC
Comment on attachment 2316 [details] [review]
A different patch

Requesting approval for my patch as well.

My patch has the advantage that it doesn't conditionalize on gcc 4, so it is
less likely to break across different compilers.
Comment 7 Stefan Dirsch 2005-04-16 12:39:35 UTC
*** Bug 2465 has been marked as a duplicate of this bug. ***
Comment 8 Stefan Dirsch 2005-04-16 13:06:31 UTC
Since it's fixed in CVS I think we can close this now. 
Comment 9 Søren Sandmann Pedersen 2005-04-17 16:40:06 UTC
As far as I can see this has not been fixed for stable.
Comment 10 Stefan Dirsch 2005-04-17 22:47:18 UTC
> As far as I can see this has not been fixed for stable. 
What is "stable"? CVS Head? 
Comment 11 Roland Mainz 2005-04-17 22:52:50 UTC
(In reply to comment #9)
> As far as I can see this has not been fixed for stable.

The approval flags are independent from the bug status
(FIXED/CLOSED/REOPENED/EVIL666/etc.) ... the bug is fixed for Xorg trunk and the
X11R6.8.x stable branch will follow once it's approved (hopefully this week) -
no need to reopen it unless more patches should follow...
Comment 12 Stefan Dirsch 2005-04-17 22:55:26 UTC
Ok. The let's close it again. 


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.