Bug 28983 - Move all QXL parsing out of red_worker.c
Summary: Move all QXL parsing out of red_worker.c
Status: RESOLVED FIXED
Alias: None
Product: Spice
Classification: Unclassified
Component: server (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Spice Bug List
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-09 07:50 UTC by Alexander Larsson
Modified: 2014-11-02 23:20 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Alexander Larsson 2010-07-09 07:50:28 UTC
We should move all qxl parsing and verifying out of red_worker.c and into red_parse_qxl.c.

For instance, all instances of get_virt() and validate_virt() should be moved.

Some of the things left to do are: red_cursor_flush, fill_cursor, handle_dev_create_primary_surface
Comment 1 Alexander Larsson 2010-07-09 07:51:12 UTC
We should also ideally be able to drop BUF_TYPE_CHUNK
Comment 2 Marc-Andre Lureau 2014-11-02 23:20:20 UTC
it seems to be somewhat "fixed" nowadays (remaining get_virt() in red_worker are not protocol related and fixed data)


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.