Bug 29128 - [r300g] nearly all CS gets rejected, rendering only garbage
Summary: [r300g] nearly all CS gets rejected, rendering only garbage
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/r300 (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Default DRI bug account
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-17 03:54 UTC by almos
Modified: 2010-07-17 08:21 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
fix (918 bytes, patch)
2010-07-17 06:36 UTC, Marek Olšák 		Details | Splinter Review
View All

Description almos 2010-07-17 03:54:36 UTC 
After the following commit: 
3eb557778376bcbbc6f25da88ffbaa269607254c is the first bad commit
commit 3eb557778376bcbbc6f25da88ffbaa269607254c
Author: Marek Olšák <maraeo@gmail.com>
Date:   Fri Jul 16 12:53:40 2010 +0200

    r300g: do not make copies of constant buffers, emit them directly

:040000 040000 a69b58bdfeed6b10709e771e09d6b0e7756c35a2 1b7411912b05b30cea9c6a3063fc5f8fb2c476b8 M	src

rendering is totally garbage in all applications I tried.

Stderr:
r300: Warning: cs_count off by -12 at (r300_emit_fs_constants, r300_emit.c:185)
debug_get_bool_option: RADEON_DUMP_CS = FALSE
radeon: The kernel rejected CS, see dmesg for more information.

dmesg:
[10445.982286] Forbidden register 0x0000 in cs at 15805
[10445.982292] [drm:radeon_cs_ioctl] *ERROR* Invalid command stream !
Comment 1 Marek Olšák 2010-07-17 04:39:56 UTC 
Fixed in master, can you confirm?
Comment 2 almos 2010-07-17 05:32:22 UTC 
The situation didn't get much better, but the error messages changed to:

stderr:
debug_get_bool_option: RADEON_DUMP_CS = FALSE
radeon: The kernel rejected CS, see dmesg for more information.

dmesg:
[18652.649971] [drm:radeon_cs_ioctl] *ERROR* Invalid command stream !
Comment 3 Marek Olšák 2010-07-17 05:44:06 UTC 
Yeah the fix introduced another regression, it should be fixed now.
Comment 4 almos 2010-07-17 06:08:31 UTC 
Now it is much better, but it's still not perfect. The intro movie of openarena is drawn in purple, and in ut2004 the map preview has inverted colors and there is no lighting at all (everything is black).
Comment 5 Marek Olšák 2010-07-17 06:36:04 UTC 
Created attachment 37148 [details] [review]
fix

Could you try the attached patch?
Comment 6 almos 2010-07-17 08:15:38 UTC 
The attached patch works.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.