Bug 29145 - AccountSet::accountRemoved is emitted for newly-created non-matching accounts
Summary: AccountSet::accountRemoved is emitted for newly-created non-matching accounts
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-qt (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/wj...
Whiteboard: r+
Keywords: patch
Depends on:
Blocks:
 
Reported: 2010-07-19 06:00 UTC by Will Thompson
Modified: 2010-07-29 23:52 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Will Thompson 2010-07-19 06:00:56 UTC 
If you create an account set, and then create a new account which doesn't match the set's filter, ::accountRemoved() is emitted by the set for the new account (even though it was never in the set).

Patch to follow.
Comment 1 Will Thompson 2010-07-19 06:02:14 UTC 
Here is a patch.

I didn't add a test case, it looked like it would be a pain. But there should really be some tests for the signals on AccountSet.
Comment 2 Andre Moreira Magalhaes 2010-07-19 06:21:01 UTC 
Looks good.
Comment 3 Andre Moreira Magalhaes 2010-07-29 23:52:46 UTC 
Merged upstream. It will be in next release 0.3.8

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.