Created attachment 37287 [details] [review]
the patch

org.freedesktop.UDisks.service.in has
SystemdService=udisks.service

but you named the file udisks-daemon.service (fwiw I'd prefer the name udisks.service)

I'd also prefer if the service was started on demand only, and not automatically by graphical.target

Oh, thanks for the pointer. The reason I named it "udisks-daemon.service" is btw that the already is the avahi service file "udisks.service" in the data dir which means we cannot reuse the name.

Yepp, it kinda sucks that we now have three types of files with the .service suffix:

- D-Bus activation files
- systemd service files
- Avahi service description files

And what's even worse is that I am to blame for at least two of these.

Created attachment 37288 [details] [review]
fix SystemdService= line in bus service file

(In reply to comment #3)
> Oh, thanks for the pointer. The reason I named it "udisks-daemon.service" is
> btw that the already is the avahi service file "udisks.service" in the data dir
> which means we cannot reuse the name.

Well, you could rename it to data/avahi/udisks.service, data/systemd/udisks.service and and probably also use data/dbus/..

Would actually be cleaner and less confusing imho.

But in the end, I'll leave it up to David

I added this (and other systemd goodies) to udisks 2.0 a while ago so closing.