Bug 29397 - Request for enhancement of the patch to get the PDF ID
Summary: Request for enhancement of the patch to get the PDF ID
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: x86 (IA32) All
: medium enhancement
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
: 29382 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-08-03 23:26 UTC by srinivas.adicherla
Modified: 2010-09-17 01:41 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
patch for getting PDF ID (8.12 KB, patch)
2010-08-03 23:26 UTC, srinivas.adicherla
Details | Splinter Review

Description srinivas.adicherla 2010-08-03 23:26:17 UTC
Created attachment 37565 [details] [review]
patch for getting PDF ID

Hi all,

       I made a patch for getting the PDF ID of the document from the trailer dictionary. It contains two IDs one is PermanentId, and otherone is UpdateId.
Please give me the feedback about the patch I attached with this mail to improve it.

  Please ignore if you receive multiple copies of the same.

 Thanks
 --
 A Srinivas
Comment 1 Carlos Garcia Campos 2010-08-04 00:32:49 UTC
*** Bug 29382 has been marked as a duplicate of this bug. ***
Comment 2 Albert Astals Cid 2010-08-14 05:48:29 UTC
Carlos, as said in the mailing list, i'm ok with the core part, it's up to you to decide about the glib/ part
Comment 3 srinivas.adicherla 2010-08-15 22:03:20 UTC
(In reply to comment #2)
> Carlos, as said in the mailing list, i'm ok with the core part, it's up to you
> to decide about the glib/ part

Hi Carlos, thank you. I put this patch in poppler mailing list. Others please give any other suggestions if you have. Thank you all.
Comment 4 Carlos Garcia Campos 2010-09-17 01:41:17 UTC
I've just pushed a patch to git master. Core part is mostly srnivias' patch slightly modified. Thanks!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.