Created attachment 37764 [details] [review] First patch: Add image names to pdftohtml dump in xml mode I wanted pdftohtml to dump information about images in a page in xml mode. The first patch below makes pdftohtml generate images as without the -xml switch and dumps its name in the xml file; please review it, I'm open to suggestions, style requests and everything required. Here is the description of the patch: The -c (complex) and -xml modes are not linked anymore. The -c switch has no real effect on -xml mode (as before). However the -i switch is now looked at in -xml mode. Without it images are now generated and image tags do reference their name. The DTD has been updated.
+ // complexMode is not anymore activated by default in xml + // output mode. + //complexMode = gTrue; Is unrelated to your patch and thus not acceptable. Please rework your patch to do what it says ("Add image names to pdftohtml dump in xml mode"), not more.
(In reply to comment #1) > + // complexMode is not anymore activated by default in xml > + // output mode. > + //complexMode = gTrue; > > Is unrelated to your patch and thus not acceptable. Please rework your patch to > do what it says ("Add image names to pdftohtml dump in xml mode"), not more. Well, the complexMode is activated by default for XML output without any clear motivation or documentation. That was the reason why images were not extracted. I intend to make a new patch with complexMode enabled again but images generated nevertheless (expect it in a week or two). Would that be ok ?
Yeah, it might not be documented, but it has been like that for ages, so better no change it if you don't have any reason. A patch that generates images when asked would be ok, eys.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/poppler/poppler/issues/309.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.