Bug 29487 - software offscreen renderer problem with fix
software offscreen renderer problem with fix
Status: RESOLVED FIXED
Product: Mesa
Classification: Unclassified
Component: Mesa core
git
Other All
: medium normal
Assigned To: mesa-dev
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-08-10 08:28 UTC by Mathias Fröhlich
Modified: 2010-08-10 20:24 UTC (History)
0 users

See Also:


Attachments
Patch to the software renderer (1.25 KB, patch)
2010-08-10 09:47 UTC, Mathias Fröhlich
Details | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mathias Fröhlich 2010-08-10 08:28:38 UTC
Hi,

I have observed and found a problem with the software renderer.
The problem happens only when we use float valued 32 bit osmesa contexts.
When we have float valued render buffers the convert_color_type function in s_span.c is not called and the
  span->array->rgba
is not set to the place in the span that would be otherwise set by the convert_color_type function.

The attached patch sets the rgba pointer to the value that matches the semantics of the convert_color_type function but the unneeded conversion is omitted.

The test case is in this case very deep in an application that does shader programs with OSMesa. I was not able to construct a simple testcase that illustrates the problem.

The patch is originally against Mesa 7.7, but still applies against todays git.

Please apply or fix appropriately

Thanks

Mathias
Comment 1 Alex Deucher 2010-08-10 09:28:23 UTC
patch?
Comment 2 Mathias Fröhlich 2010-08-10 09:47:35 UTC
Created attachment 37771 [details] [review]
Patch to the software renderer

Sorry, I am pretty sure that I had filled that already in the initial new bug page. To be honest, I fail to get the initial patch often. But I do not know what I miss in the initial bug page so that the initial submission gets sent without patch.

Mathias
Comment 3 Brian Paul 2010-08-10 20:24:11 UTC
Thanks.  Patch applied as commit c8e714df013cdf360602f9cc96d26cb732b19a32 (with minor changes).