Gabble gets various compiler warnings with gcc-4.5. Cosimo has a branch with various changes, about which I said: > > - g_assert ((priv->state == JS_STATE_PENDING_CREATED) || > > - (priv->state == JS_STATE_ENDED)); > > + g_assert ((priv->state == (JingleState) JS_STATE_PENDING_CREATED) || > > + (priv->state == (JingleState) JS_STATE_ENDED)); > > [...] I don't like scattering casts through our code if we don't > have to; they clutter the code (hurting clarity), and can mask genuine bugs > that the compiler would have warned us about.
Here are (IMO) some better fixes for gcc 4.5 compilation: * the muc-channel patch in the previous branch was hiding a genuine bug, which gcc spotted for us :-) * the tube and Jingle things were some minor abuse of numerically-equal enums - harmless, but confusing - which I've tidied up * in gabble_media_factory_get_contact_caps we did in fact know better than the compiler, so I added a cast, together with a comment explaining why we're right
r+ from Sjoerd for a modified branch, fixed in git for 0.9.16.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.