I have talloc installed in /usr/local/samba and "pkg-config --cflags talloc" returns -I/usr/local/samba/include as it should. This is correctly set in configs/current; however, it doesn't seem to make it to CFLAGS and CXXFLAGS which makes the build die.
For now I manually added $(TALLOC_CFLAGS) to CFLAGS and CXXFLAGS, which works.
Ping! I just updated to the git/master. The problem remains.
Folks, this should be trivial to fix, but hasn't been.
How are you building Mesa?
What is your proposed patch?
I don't see a problem here. TALLOC_CFLAGS seems to be used where needed when I build here.
I haven't seen a problem either (I build with autogen.sh then make).
I too build with autogen.sh (with "--enable-gallium-nouveau --enable-gallium-radeon) and then make. The problem isn't that TALLOC_CFLAGS is incorrect, rather it doesn't seem to be used in the Makefile's CFLAGS. I "fixed" the problem by making a symlink to talloc.h in /usr/local/include which is part of the default search path. My bet is that the reason you don't see the problem is that your talloc installation is to /usr or /usr/local, and the includes end up in the default places. My installation puts them into /usr/local/samba.
Where exactly does the build fail, though?
The INCLUDES variable in src/glsl/Makefile should be covering this.
Created attachment 39151 [details] [review]
add TALLOC_CFLAGS in src/mesa/Makefile
(In reply to comment #6)
Okay, I tried it myself by moving talloc.h out of its normal location and hardcoding TALLOC_CFLAGS to point to it in configure.ac, and I fixed the problem. Apparently talloc *isn't* just used by the new glsl2 compiler, but nobody told the Makefiles. Patch 1 attached. (can these go in 7.9?)
Created attachment 39152 [details] [review]
add TALLOC_CFLAGS to i965 classic driver
Also, this was using the wrong Makefile variable (INCLUDES is just overwritten by Makefile.template) - so is i915, btw.
this is obsoleted by the change to use an internal talloc-like library.
*** Bug 29620 has been marked as a duplicate of this bug. ***