Bug 30155 - [i915 bisected] pigilit general_draw-elements-vs-inputs fails
Summary: [i915 bisected] pigilit general_draw-elements-vs-inputs fails
Status: VERIFIED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/i915 (show other bugs)
Version: git
Hardware: Other All
: high major
Assignee: Kristian Høgsberg
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-12 20:23 UTC by jiajia
Modified: 2010-10-08 19:22 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description jiajia 2010-09-12 20:23:07 UTC
Kernel_version:		2.6.36-rc2_unstable_20100908+
Libdrm:		(master)2.4.21-21-g7ec9a1effa4f551897f91f3b017723a8adf011d9
Mesa:		(master)67763488b1fea01d6eb1c7d9e05ecb175918c3af

Problem:
pigilit general_draw-elements-vs-inputs fails, which is a regression. 

Output:
Probe at (75,100)
  Expected: 1.000000 0.039000 0.039000
  Observed: 0.501961 0.501961 0.501961
Probe at (150,100)
  Expected: 0.615000 0.039000 0.039000
  Observed: 0.501961 0.501961 0.501961
Probe at (225,100)
  Expected: 1.000000 0.039000 0.039000
  Observed: 0.501961 0.501961 0.501961
Probe at (75,200)
  Expected: 1.000000 0.039000 0.039000
  Observed: 0.501961 0.501961 0.501961
Probe at (225,200)
  Expected: 1.000000 0.039000 0.039000
  Observed: 0.501961 0.501961 0.501961
PIGLIT: {'result': 'fail' }

Bisected:
94118fe2d4b1e5d0b9f39d9d2c44706db462e97e is first bad commit
tree 439ac2d0920eb2aca8f0805c7fa1d8e7036b98c7
parent 916c8ed2c8f916604166b22e6fcb9433b960a924
author Kristian Høgsberg <krh@bitplanet.net> 1284052720 -0400
committer Kristian Høgsberg <krh@bitplanet.net> 1284052723 -0400

glx: Optimize out no-op make current calls

This make a lot more sense now that we might have to recreate the
glx drawables for legacy code paths.
Comment 1 Kristian Høgsberg 2010-09-13 05:59:23 UTC
I can't reproduce this one.  What's your X server version and what HW are you using?
Comment 2 jiajia 2010-09-13 18:53:22 UTC
(In reply to comment #1)
> I can't reproduce this one.  What's your X server version and what HW are you
> using?
Platform: Pineview
Xserver:  (master)xorg-server-1.9.0
I forgot to mention that this issue does not exists in i965.
Comment 3 Kristian Høgsberg 2010-09-22 14:35:44 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > I can't reproduce this one.  What's your X server version and what HW are you
> > using?
> Platform: Pineview
> Xserver:  (master)xorg-server-1.9.0
> I forgot to mention that this issue does not exists in i965.

Can you try the patch in 29984, comment 2?
Comment 4 Kristian Høgsberg 2010-09-22 14:45:45 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > I can't reproduce this one.  What's your X server version and what HW are you
> > > using?
> > Platform: Pineview
> > Xserver:  (master)xorg-server-1.9.0
> > I forgot to mention that this issue does not exists in i965.
> 
> Can you try the patch in 29984, comment 2?

Actually, I just committed it to master, so just give that a try and see if it helps.
Comment 5 fangxun 2010-09-25 02:03:50 UTC
The test result is pass on master branch.
Comment 6 Kristian Høgsberg 2010-09-29 06:18:36 UTC
Fixed by

commit 86a1938aa56c02d7da137b09e579d24d7da50d9e
Author: Kristian Høgsberg <krh@bitplanet.net>
Date:   Wed Sep 22 17:34:00 2010 -0400

    glx: Invalidate buffers after binding a drawable
    
    If the server doesn't send invalidate events, we may miss a
    resize before the rendering starts.  Invalidate the buffers now
    so the driver will recheck before rendering starts.

which was cherry-picked back to 7.9 as 7d154de04883c7b83dbc1a4619a1d6d8758dc07e.
Comment 7 fangxun 2010-10-08 19:22:48 UTC
Verified with the fixed commit.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.