Bug 30251 - PackageKit does not handle split media repos correctly
Summary: PackageKit does not handle split media repos correctly
Status: RESOLVED FIXED
Alias: None
Product: PackageKit
Classification: Unclassified
Component: backend-yum (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Richard Hughes
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-18 03:40 UTC by Hedayat Vatankhah
Modified: 2010-09-20 03:50 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Fix the split media handling in PackageKit yum backend (1.59 KB, patch)
2010-09-18 03:40 UTC, Hedayat Vatankhah
Details | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Hedayat Vatankhah 2010-09-18 03:40:04 UTC
Created attachment 38779 [details] [review]
Fix the split media handling in PackageKit yum backend

There are two problems with split media handling in PackageKit:
1. When it prompts for inserting media, it doesn't mention the disk/volume number. For example, it should say: Please insert media labeled "Fedora 13 CD #2" but it says: Please insert media labeled "Fedora 13"

2. When you remove the first disk and insert another disk, the media repository is disabled so you can't continue

The attached patch fixes both issues; the last part fixes issue 1 by including the disc number in the message (It'll be never used by single media repos, as they are disabled if not available). The other parts fix the second problem: the media repo is not disabled while any of the disks are available. This works fine in all situations and packagekit requests other disks when needed (for example if there is no cache from that repo, it'll correctly tells the user to insert the first disk).
Comment 1 Richard Hughes 2010-09-20 03:50:05 UTC
Both pushed to master, thanks:

commit dcb3369660a926f69f48ffa288163ae1505db11a
Author: Hedayat Vatankhah <hedayat@grad.com>
Date:   Mon Sep 20 11:50:08 2010 +0100

    yum: Fix the split media handling in PackageKit yum backend
    
    Signed-off-by: Richard Hughes <richard@hughsie.com>

:100755 100755 14a022d... 7490644... M  backends/yum/yumBackend.py

commit facb22c96a2dd6afa1bc80fbb5984affa3efb9be
Author: Hedayat Vatankhah <hedayat@grad.com>
Date:   Mon Sep 20 11:49:28 2010 +0100

    When prompting for media, include the disc number
    
    Signed-off-by: Richard Hughes <richard@hughsie.com>

:100755 100755 b261308... 14a022d... M  backends/yum/yumBackend.py


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.