Bug 30304 - stop using tp_get_bus()
Summary: stop using tp_get_bus()
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: 0.11
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/sm...
Keywords: patch
: 30308 (view as bug list)
Depends on:
Blocks: 24114 30308
  Show dependency treegraph
Reported: 2010-09-21 05:58 UTC by Simon McVittie
Modified: 2010-09-28 03:49 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Description Simon McVittie 2010-09-21 05:58:28 UTC
+++ This bug was initially created as a clone of Bug #24114 +++

tp_get_bus() calls exit(), which is Bad™. We can't remove it til we break ABI, but we can at least deprecate it.

This branch stops using it in Gabble.
Comment 1 Guillaume Desmottes 2010-09-22 00:16:33 UTC
You don't unref the bus in call-stream-endpoint.c.
Comment 2 Simon McVittie 2010-09-22 09:58:49 UTC
*** Bug 30308 has been marked as a duplicate of this bug. ***
Comment 3 Simon McVittie 2010-09-22 10:01:24 UTC
(In reply to comment #1)
> You don't unref the bus in call-stream-endpoint.c.

Fixed (it would have conflicted with my get-bus branch, which you already approved, so I merged that branch into this one first). The resulting branch has one unreviewed commit.
Comment 4 Simon McVittie 2010-09-22 10:11:41 UTC
Bonus extra branch: http://git.collabora.co.uk/?p=user/smcv/telepathy-gabble-smcv.git;a=shortlog;h=refs/heads/010-leaks contains backports of the leak fixes I spotted while fixing Bug #30308 to the 0.10 branch.
Comment 5 Guillaume Desmottes 2010-09-23 00:23:34 UTC
++ for both branches
Comment 6 Simon McVittie 2010-09-28 03:49:17 UTC
Fixed in git for 0.10.1 (leaks only) and 0.11.0 (tp_get_bus, tp_clear_object).

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.