Bug 30348 - Implement a Protocol object
Summary: Implement a Protocol object
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: salut (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/sm...
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2010-09-23 09:13 UTC by Simon McVittie
Modified: 2010-10-18 09:08 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Simon McVittie 2010-09-23 09:13:58 UTC 
To make Protocol something we can rely on, all CMs should have Protocol objects. My protocol branch adds one to Salut.

This also depends on some of the changes from my 'misc' branch.
Comment 1 Simon McVittie 2010-10-01 06:56:20 UTC 
Rebased with extra actually working, and a regression test, now that regression tests in general work better.
Comment 2 Simon McVittie 2010-10-18 09:08:58 UTC 
15:19 < tomeu> smcv: so the only comment I have about the protocol branch is 
               that some indenting in write-mgr-file.c is inconsistent, but I 
               guess the code style may not be unambiguous in that case and 
               that it's due to have been picked from gabble and having several 
               authors

I'm going to merge this anyway; consistent indentation for switch() would be nice, but I don't think it should block this.

Fixed in git for 0.5.0.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.