Could you attach full lspci? I assume this should be ati bug instead of intel...

Gordon, please test and verify if display hotplug works on Huron river or not.

VGA hotplug works on my Sandy Bridge D1 [0126], with 2.6.36-rc4 kernel.

An easy way to identify our hotplug event is by using 'udevadm' utility, e.g

$udevadm monitor --kernel

you should see new event message when you plug in/out outputs.

Hi Wang Zhenyu,

I tried $udevadm monitor --kernel and I am not seeing any event when VGA cable is plugged in/out.

Attached is the lspci output of my system.

Created attachment 38999 [details]
lspci output attached

This is not ATI specific. I tried on UMA also and no udev events are generated. The attached lspci logs are from my UMA system.

We have added some printk s to ironlake_irq_handler code and observed that no PCH event is getting generated. But xrandr shows VGA monitor after hotplugging.

Wang Zhenyu - are seeing any udev-event with 2.6.36-rc4 kernel?

We have tested this issue on UMA with 2.6.36-rc6 kernel and no Uevent is occurring with VGA hot plug. 
-No uvent is appearing(udevadm monitor –kernel) on Huron river UMA with 2.6.36-rc6 kernel with VGA hot plug. But could switch to external monitor using xrandr after hot plug.

Question- Are you guys seeing any uevent with VGA hot plug on your boards.

Using [SNB] as the tag for bugs specific to Sandybridge hardware.

Created attachment 39278 [details] [review]
The patch to fix this issue

Hi Manjeet, 

Please try this patch. It fixed this issue on my side.


Thanks.

Yuanhan, good catch!

Some comments for your patch.

We should split SDE_HOTPLUG_MASK for IBX and CPT as well. As they represent different hotplug mask bits, so we should check them differently in irq hander.

Do you really need to force CRT hotplug enable in detect? We save CRT control before detection, then restore it back, so things should be good.

Hi Zhenyu, 

Thanks for your comments.

(In reply to comment #11)
> Do you really need to force CRT hotplug enable in detect? We save CRT control
> before detection, then restore it back, so things should be good.

Yes, just as the commnets said: 'Make sure....'. And, the HOTPLUG bit is disabled by default.

Thanks.

Applied to drm-intel-next

commit 1510a97182b4ddb5fe3c4e8d05240f7cd6fd13e7
Author: Yuanhan Liu <yuanhan.liu@intel.com>
Date:   Fri Oct 8 10:18:01 2010 +0100

    drm/i915/crt: Make sure the hotplug interrupt is enabled
    
    After disabling the hotplug interrupts for VGA detection on Ironlake, be
    sure to re-enable them again afterwards.
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=30378
    Signed-off-by: Yuanhan Liu <yuanhan.liu@intel.com>
    Cc: stable@kernel.org
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>


commit 2d7b8366ae4a9ec2183c30e432a4a9a495c82bcd
Author: Yuanhan Liu <yuanhan.liu@intel.com>
Date:   Fri Oct 8 10:21:06 2010 +0100

    drm/i915: Update hotplug interrupts register definitions for Sandybridge
    
    On Sandybridge, the bit definition for hotplug on SDE has changed, so
    update the code to new definition.
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=30378
    Cc: stable@kernel.org
    Signed-off-by: Yuanhan Liu <yuanhan.liu@intel.com>
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

hotplug events are working after applying this patch.

Thanks,
Manjeet

Tested-by: Sun Yi <yi.sun@intel.com>

Verified->Closed.