Bug 30434 - CM sends excessive codecs in SDP reply
Summary: CM sends excessive codecs in SDP reply
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: rakia (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Mikhail Zabaluev
QA Contact: Telepathy bugs list
URL: http://cgit.freedesktop.org/~zabaluev...
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2010-09-28 11:23 UTC by Olivier Crête
Modified: 2011-06-14 11:32 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Olivier Crête 2010-09-28 11:23:49 UTC
Scenario:

tp-ssip gets incoming call from Polycom phone with:
PCMU/8000
telepathy-event/8000 events=0-15

It creates a telepathy channel
- tp-farsight calls Ready() with all the possible codecs
- tp-ssip emits SetRemoteCodecs() with only PCMU & telephone-events
- tp-farsights calls SupportedCodecs() with only PCMU & telephone-events

Observed:
- tp-ssip sends a SDP reply with PCMU & telephone-events first, but then gives all the other codecs afterwards

Expected:
- tp-ssip sends a SDP with only PCMU & telephone-events

So, what I'm saying is that tp-ssofia should flush its existing list of codecs when it gets SupportedCodecs() or CodecsChanged() and just send its next SDP with that.
Comment 1 Olivier Crête 2010-09-28 11:28:58 UTC
Btw, I should mention that this is not strictly wrong, but that it may confuse crappy implementations.
Comment 2 Mikhail Zabaluev 2011-06-01 03:05:55 UTC
Fixing this while dealing with a separate issue: reinvite-happiness caused by CodecsUpdated.
Comment 3 Mikhail Zabaluev 2011-06-07 09:03:27 UTC
Fixed in this branch:
http://cgit.freedesktop.org/~zabaluev/telepathy-rakia/log/?h=codec-updates
Comment 4 Mikhail Zabaluev 2011-06-14 11:32:56 UTC
Merged to master and telepathy-sofiasip-0.6, and released in telepathy-sofiasip 0.6.8


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.