Bug 30657 - Doesn't register handler for privacy list pushes early enough
Summary: Doesn't register handler for privacy list pushes early enough
Status: NEW
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-06 07:10 UTC by Will Thompson
Modified: 2010-10-06 07:10 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Will Thompson 2010-10-06 07:10:20 UTC
I was debugging an invisibility-related bug today. When connecting, Gabble retrieves a list of privacy lists from the server, and if no suitable invisible list exists, tries to create one. Only once it has successfully found or created an invisible list does it register a handler for privacy list pushes.

I don't think this can cause any user-visible problems: there's no window between it determining a list is valid and registering the handler in which a push invalidating the list could be received.

But, if we create a privacy list during connection, we get a push for that newly-created list... before we've registered the handler. So Gabble sends back an IQ error, claiming it doesn't understand privacy lists... which seems wrong, and made me panic.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.