Bug 30663 - fontutil.m4: Add a shorthand --disable-all-encodings option
fontutil.m4: Add a shorthand --disable-all-encodings option
Status: RESOLVED FIXED
Product: xorg
Classification: Unclassified
Component: Fonts/other
git
All All
: medium enhancement
Assigned To: Xorg Project Team
Xorg Project Team
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-10-06 12:19 UTC by Michał Górny
Modified: 2010-10-07 17:28 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Patch to add the --disable-all-encodings option (2.02 KB, patch)
2010-10-06 12:19 UTC, Michał Górny
no flags Details | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny 2010-10-06 12:19:52 UTC
Created attachment 39239 [details] [review]
Patch to add the --disable-all-encodings option

It would be useful if font packages provided '--disable-all-encodings' option.

Right now, we have to specify all disabled encodings one by one -- and as different fonts provide different encodings, we either have to keep a clear encoding list for each font or struggle with configure warnings about unknown options.

Instead, we could simply pass a kind of '--disable-all-encodings' option to disable all font encodings supported by a font. Afterwards, '--enable-<encoding>' could be used to re-enable a single encoding.

I'm attaching a patch to provide the described behavior in XORG_FONT_CHECK_ENCODING_LIST() macro. Details are described inside the patch.

Related Gentoo bug: http://bugs.gentoo.org/show_bug.cgi?id=339852
Comment 1 Rémi Cardona 2010-10-06 22:52:42 UTC
@Michał,

Please send this patch to xorg-devel. It probably will be forgotten if it stays in bugzilla.

Cheers
Comment 2 Alan Coopersmith 2010-10-07 17:28:36 UTC
Pushed to git master for inclusion in font-util 1.2.0 after the review on
xorg-devel:
http://cgit.freedesktop.org/xorg/font/util/commit/?id=62529733e57b6d6c775b1bcf584260b1cff6af5c