13:22 < jonnylamb> wjt, sjoerd, smcv: What would you guys say to having some kind of tp:immutable="yes" atribute or something to properties so that it's much easier to see whether a property is immutable without having some free-form "this is an immutable property" text in the property description? 13:22 < jonnylamb> just to make it really clear and easy to notice which are immutable 13:22 < smcv> jonnylamb: for channels etc, sure 13:23 < smcv> jonnylamb: (Connection is a bit weird though, it has a lot of "immutable after CONNECTED" properties that don't really fit) 13:23 < wjt> tp:immutable='after Connected' 13:23 < wjt> but for channels it's obviously a good idea 13:24 < smcv> yeah, it's most important for channels 13:24 < jonnylamb> Okay I'll get on that. I'll probably leave it with channel properties for now. I did it! Feel free to bikeshed the colours I chose and even how exactly it's displayed per property.
Just ignore the fact that I've only done it for Chan.I.Conference for now. I'll get around to doing it for the others some time soon.
<td>$property.get_access()</td> + <td>$property.get_flag_summary()</td> <td> Surely you should be updating a colspan='' attribute on cells in some other rows? (I actually don't know if HTML strictly requires you to be that pedantic.) + <div class="annotation immutable">This property is + <strong>immutable</strong> which means that it can never change + once the channel has been given its original value. How about “This property is *immutable*, which means that its value can never change once the channel has been created.”? such as in + the <a href="Connection_Interface_Requests.html#org.freedesktop.Telepathy.Connection.Interface.Requests.CreateChannel">CreateChannel</a> + method.</div> “as passed to CreateChannel() and EnsureChannel() on Requests and ChannelDispatcher”?
(In reply to comment #2) > Surely you should be updating a colspan='' attribute on cells in some other > rows? (I actually don't know if HTML strictly requires you to be that > pedantic.) No? The table I am adding a new column to doesn't have any rows that span multiple columns. > How about “This property is *immutable*, which means that its value can never > change once the channel has been created.”? OK > “as passed to CreateChannel() and EnsureChannel() on Requests and > ChannelDispatcher”? fair, OK. I also added a couple of other patches. No rebasin' though, for your reviewing comfort, lolbags!!!!!!!!!!!!!
looks good.
Merged, thanks!
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.