Bug 30792 - Cleanup Sandisk media players
Summary: Cleanup Sandisk media players
Status: RESOLVED FIXED
Alias: None
Product: media-player-info
Classification: Unclassified
Component: New device (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Martin Pitt
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-12 00:20 UTC by Jonathan Ernst
Modified: 2010-10-12 03:07 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
patch (8.73 KB, patch)
2010-10-12 00:21 UTC, Jonathan Ernst
Details | Splinter Review

Description Jonathan Ernst 2010-10-12 00:20:15 UTC
Remove MTP USB Ids
Split devices to have correct names
Add new devices

(see attached patch)
Comment 1 Jonathan Ernst 2010-10-12 00:21:26 UTC
Created attachment 39359 [details] [review]
patch
Comment 2 Martin Pitt 2010-10-12 03:02:33 UTC
Apparently you changed

-Product=Sansa e130, e140
-DeviceMatch=usb:0781:7301;usb:0781:7302;

to

+Product=Sansa e100 Series
+DeviceMatch=usb:0781:7302;

i. e. the 7301 product ID was dropped. Juding by the "e100 series" title, you were meaning to add this to the new DeviceMatch?

A few product IDs from media-players/sandisk-7432_7433_7434_7435_74c0_74c1_74c2_74c3.mpi also got dropped now.
Comment 3 Martin Pitt 2010-10-12 03:03:02 UTC
Oh, are these the MTP IDs?
Comment 4 Martin Pitt 2010-10-12 03:07:29 UTC
I checked http://www.qbik.ch/usb/devices/search.php and http://www.linux-usb.org/usb.ids, and unfortunately neither of those has the 7301 product ID.

http://www.linux-usb.org/usb.ids confirms the MTP modes for usb:0781:7432 and friends.

So I pushed this, thanks!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.