Bug 30808 - Typo in Git-commit 4083197a44d1a1a05d33654b3c7d6e96d7472fe7
Summary: Typo in Git-commit 4083197a44d1a1a05d33654b3c7d6e96d7472fe7
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/intel (show other bugs)
Version: git
Hardware: x86 (IA32) Linux (All)
: medium normal
Assignee: Carl Worth
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
: 30816 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-10-12 12:36 UTC by Stefan Glasenhardt
Modified: 2010-10-13 01:53 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
Small patch to correct typo in Git-commit 4083197a44d1a1a05d33654b3c7d6e96d7472fe7 (622 bytes, patch)
2010-10-12 12:36 UTC, Stefan Glasenhardt 		no flags Details | Splinter Review
View All

Description Stefan Glasenhardt 2010-10-12 12:36:41 UTC 
Created attachment 39390 [details] [review]
Small patch to correct typo in Git-commit 4083197a44d1a1a05d33654b3c7d6e96d7472fe7

Hi,

The current git-code has a small typo which makes hardware-accelerated OpenGL on 8xx-based chipsets impossible :

- info.driverName = IS_I965G(intel) ? "i965" : "i915";
+ info.driverName = IS_GEN3(intel) ? "i915" : "i965";

The order of the names was changed and now the module "i965_dri.so" is loaded for 8xx-based chipsets and "i915_dri.so" for 9xx based and newer chipsets.

Greetings

Stefan
Comment 1 Julien Cristau 2010-10-13 01:42:20 UTC 
*** Bug 30816 has been marked as a duplicate of this bug. ***
Comment 2 Chris Wilson 2010-10-13 01:53:33 UTC 
After a bout of rage, Julien reminded me that it still needed fixing.

commit 8507ef50ba08061ac158848a7c4c136e1755d87e
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Wed Oct 13 09:45:59 2010 +0100

    Fix driverName regression for i830 from 4083197a
    
    Reported-by: Stefan Glasenhardt <stefan@glasen-hardt.de>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=30808
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.