Bug 30958 - EGL pipe_i965.c uses inline sw_screen_wrap() without including inline_wrapper_sw_helper.h
Summary: EGL pipe_i965.c uses inline sw_screen_wrap() without including inline_wrapper...
Status: CLOSED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Other (show other bugs)
Version: git
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: mesa-dev
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-18 04:49 UTC by Victor Tseng
Modified: 2010-10-23 05:49 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Victor Tseng 2010-10-18 04:49:28 UTC
src/gallium/targets/egl/pipe_i965.c calling sw_screen_wrap() without including target-helpers/inline_wrapper_sw_helper.h cause installation on gentoo to fail with "installation aborted due to poor programming practices".

the header file of the static inline function should be included before using the function.

Solution:
add #include "target-helpers/inline_wrapper_sw_helper.h" to pipe_i965.c.
Comment 1 Brian Paul 2010-10-18 06:59:13 UTC
Fixed w/ commit e19187e1beee9ea962f6d86cc4964b38fbcf768b


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.