Bug 31264 - Xkbcomp-1.2.0 cross compilation is broken
Summary: Xkbcomp-1.2.0 cross compilation is broken
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: App/xkbcomp (show other bugs)
Version: unspecified
Hardware: Other All
: medium blocker
Assignee: Gaetan Nadon
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-31 13:40 UTC by Abdoulaye Walsimou Gaye
Modified: 2010-11-01 09:49 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
replace AC_CHECK_FILE with test -f as it fails to cross-compile (1.18 KB, patch)
2010-10-31 18:13 UTC, Gaetan Nadon
no flags Details | Splinter Review

Description Abdoulaye Walsimou Gaye 2010-10-31 13:40:14 UTC
Xkbcomp-1.2.0 cross compilation is broken due to commit 988eb0e121c0f.
This commit uses AC_CHECK_FILE which produces a fatal error in case of cross compilation:
checking for ./xkbparse.c... configure: error: cannot check for file existence when cross compiling.

Please do not use autoconf AC_CHECK_FILE macro it breaks cross compilation.
Comment 1 Alan Coopersmith 2010-10-31 13:49:10 UTC
That was added in commit 988eb0e121c0f2c992031002acb7274c2026764b:
Author: Gaetan Nadon <memsize@videotron.ca>
Date:   Mon Jul 12 10:53:34 2010 +0100

    config: allow to build tarball when yacc is missing


http://cgit.freedesktop.org/xorg/app/xkbcomp/commit/?id=988eb0e121c0f2c992031002acb7274c2026764b
Comment 2 Gaetan Nadon 2010-10-31 18:13:54 UTC
Created attachment 39937 [details] [review]
replace AC_CHECK_FILE with test -f as it fails to cross-compile

Would you try this patch?
There are 2 other modules with the same test.
Comment 3 Martin Jansa 2010-11-01 02:34:33 UTC
(In reply to comment #2)
> Created an attachment (id=39937) [details]
> replace AC_CHECK_FILE with test -f as it fails to cross-compile
> 
> Would you try this patch?
> There are 2 other modules with the same test.

Yes this works, thanks!

Actually there are 3 other modules using it.

I've filled #31287, #31288, #31289 with patches when I was adding those new apps to OpenEmbedded repo.

Similar issue (but not with yacc test) was filled in #31290 also with patch.

Thanks!

Regards,
Comment 4 Abdoulaye Walsimou Gaye 2010-11-01 03:04:49 UTC
also works here!
Tested-by: Abdoulaye Walsimou Gaye <awg@embtoolkit.org>


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.